Conversation
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
- Please reference the private repo PR corresponding to this
- Please pull down latest changes from upstream and run code generation again
Add code to record tests when they change.
Update version per CR feedback
areddish
force-pushed
the
custom-vision-2.0
branch
from
1fab8b1 to
02309f0
Compare
|
Private repo PR is https://github.com/Azure/azure-sdk-for-net-pr/pull/832 Pulled upstream, rebased off it and re-ran code gen, only the metadata changed. |
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
Versioning inconsistent with the private repo PR, please verify
| <PackageId>Microsoft.Azure.CognitiveServices.Vision.CustomVision.Prediction</PackageId> | ||
| <Description>This client library provides access to the Microsoft Cognitive Services CustomVision Prediction APIs.</Description> | ||
| <VersionPrefix>0.9.0-preview</VersionPrefix> | ||
| <Version>0.10.0-preview</Version> |
There was a problem hiding this comment.
There is a diff here with the private repo PR.
Also, PackageReleaseNotes indicate this is not a preview release but the Version does, please verify the intent here
There was a problem hiding this comment.
Yes, I was asked to modify the version and update the preview outside of the private pr. I can send you the info so you can validate.
| <PackageId>Microsoft.Azure.CognitiveServices.Vision.CustomVision.Training</PackageId> | ||
| <Description>This client library provides access to the Microsoft Cognitive Services CustomVision Training APIs.</Description> | ||
| <VersionPrefix>1.0.2-preview</VersionPrefix> | ||
| <Version>0.10.0-preview</Version> |
There was a problem hiding this comment.
Don't think you can go back versions, also differs from the private repo entry, please check the versioning here
| ApiKey = TrainingKey | ||
| ApiKey = TrainingKey, | ||
| #if RECORD_MODE | ||
| //BaseUri = new Uri("https://deviris2.azure-api.net/V2.0/Training") //new Uri("http://localhost:8080/api_v2.0/training") |
| ApiKey = TrainingKey, | ||
| #if RECORD_MODE | ||
| //BaseUri = new Uri("https://deviris2.azure-api.net/V2.0/Training") //new Uri("http://localhost:8080/api_v2.0/training") | ||
| BaseUri = new Uri("https://cognitivescusppe.azure-api.net/customvision/v2.0/Training") |
There was a problem hiding this comment.
Do we still need the BaseUri in RECORD_MODE?
There was a problem hiding this comment.
It depends on how it's recorded, I'm not using it for Prediction so I'm keeping it consistent between Prediction and Training.
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
LGTM apart from the question
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
Will merge on CIs passing
2 participants
Description
Regenerate client for v2.0 Swagger
Update tests for new functionality
Update tests to be able to record session when needed
Public submission from private PR#454
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.