Skip to content

Comments

[ADLA] - Support catalog list table fragments#4276

Merged
dsgouda merged 2 commits intoAzure:psSdkJson6from
idear1203:adla_support_list_table_fragments
May 10, 2018
Merged

[ADLA] - Support catalog list table fragments#4276
dsgouda merged 2 commits intoAzure:psSdkJson6from
idear1203:adla_support_list_table_fragments

Conversation

@idear1203
Copy link
Contributor

@idear1203 idear1203 commented May 2, 2018

Description

Swagger PR Links

Changes in 3.4.0-preview


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@idear1203 idear1203 changed the title [ADLA] - support list table fragments [ADLA] - Support catalog list table fragments May 2, 2018
@ro-joowan ro-joowan self-requested a review May 2, 2018 19:37
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run msbuild build.proj /t:build /p:Scope=SDKs\DataLake.Analytics
and commit any changes to the .props file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this file is being updated, @idear1203 which generate.cmd was run to generate the code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use this generate.cmd: src/SDKs/DataLake.Analytics/Management.DataLake.Analytics/generate.cmd.

This file seems updating frequently.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is updated every time we run the code generation script to log some essential code generation details.

@dsgouda
Copy link
Contributor

dsgouda commented May 9, 2018

Please update the branch with upstream

@idear1203 idear1203 force-pushed the adla_support_list_table_fragments branch from 859a65a to 9204ebc Compare May 10, 2018 05:41
@idear1203
Copy link
Contributor Author

The branch has been updated with upstream as request.

@idear1203
Copy link
Contributor Author

I have run the command msbuild build.proj /t:build /p:Scope=SDKs\DataLake.Analytics, but I cannot see any new changes.

BTW, it seems there is no such .props file under src\SDKs\DataLake.Analytics.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 592c77e into Azure:psSdkJson6 May 10, 2018
@idear1203 idear1203 deleted the adla_support_list_table_fragments branch May 14, 2018 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants