Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use package.json for autorest in sdk repo #42524

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Use package.json for autorest in sdk repo #42524

merged 4 commits into from
Mar 11, 2024

Conversation

hallipr
Copy link
Member

@hallipr hallipr commented Mar 7, 2024

Calling npx autorest from the GenerateCode target has been causing build breaks under heavy load in parallel. Preempting the call with npm ci over a lock file is both safer for CI and makes the npx call local and pre-cached

@hallipr hallipr force-pushed the users/pahallis/npx-autorest branch from 0cc0690 to 41f5d8f Compare March 7, 2024 19:39
hallipr added 2 commits March 11, 2024 10:38
@hallipr
Add package json and invoke npm ci for code gen
72a5603
@hallipr
Move
f43d53f 
pm ci call to earlier in Update-dotnet-GeneratedSdks
@hallipr hallipr force-pushed the users/pahallis/npx-autorest branch from 41f5d8f to f43d53f Compare March 11, 2024 17:45
@hallipr hallipr marked this pull request as ready for review March 11, 2024 20:21
@hallipr hallipr requested review from weshaggard, benbp, jsquire, pallavit and a team as code owners March 11, 2024 20:21
@hallipr hallipr requested a review from m-nash March 11, 2024 20:21
@hallipr
Copy link
Member Author

hallipr commented Mar 11, 2024

This change is seen in the Analyze job of all service ci pipelines:
https://dev.azure.com/azure-sdk/public/_build/results?buildId=3583917&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=2102385d-609d-5572-64d2-932661c7902f&l=91

and in the "Call regeneration script" step of the autorest.csharp - preview pipeline:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3582677&view=logs&j=a8b71f47-adde-58ec-fdc6-95a570a1f8eb&t=63ae3c56-12d4-5281-e32a-40a56ab1e20e&l=154

@hallipr hallipr requested a review from mikeharder March 11, 2024 20:42
m-nash
m-nash approved these changes Mar 11, 2024
View reviewed changes
mikeharder
mikeharder approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@mikeharder mikeharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we run several builds with this PR, to be confident it fixes the race condition?

@hallipr hallipr merged commit 3092f46 into main Mar 11, 2024
64 checks passed
@hallipr hallipr deleted the users/pahallis/npx-autorest branch March 11, 2024 23:28
This was referenced Mar 12, 2024
Closed
Closed
angiurgiu pushed a commit that referenced this pull request Mar 20, 2024
@hallipr @angiurgiu
Use package.json for autorest in sdk repo (#42524)
462e2f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeharder mikeharder mikeharder approved these changes

@m-nash m-nash m-nash approved these changes

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

@benbp benbp Awaiting requested review from benbp benbp is a code owner

@jsquire jsquire Awaiting requested review from jsquire jsquire is a code owner

@pallavit pallavit Awaiting requested review from pallavit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hallipr @mikeharder @m-nash