-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[NOT AZURE] Updated Azure Stack Infrastructure Insights Admin SDK #4252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NOT AZURE] Updated Azure Stack Infrastructure Insights Admin SDK #4252
Conversation
dsgouda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just needs a version bump
| <TargetFrameworks>net452;netstandard1.4</TargetFrameworks> | ||
| </PropertyGroup> | ||
| <PropertyGroup> | ||
| <PackageId>Microsoft.AzureStack.Management.InfrastructureInsights.Admin</PackageId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this package is already published and there are some additive changes being introduced. Please update the package version number
|
@dsgouda Done! Also, do we publish the Nugets? We might have to update the package release notes. |
|
@deathly809 I believe so, please check here |
|
@dsgouda I already updated the version. So I have to kick off the build process correct? Just to be 100% clear. |
|
By build if you mean publish the package, then yes. The "build" itself was done successfully here by the CI machines. |
|
@dsgouda I have been trying to get feedback on that. We might just have a single PR to update all the admin PackageReleaseNotes and then kick of a publish job. |
|
That would be a good idea. Will merge this for now, feel free to open a new PR for the release notes. |
dsgouda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Recreated the FRP specifications and regenerated the SDK.
Azure/azure-rest-api-specs#2812
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.