-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Content Moderator- Set language as a non-required field for Screen Text API #4240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dsgouda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a generate.ps1 file similar to this and regenerate the code.
| [assembly: AssemblyVersion("0.11.0.0")] | ||
| [assembly: AssemblyFileVersion("0.11.0.0")] | ||
| [assembly: AssemblyVersion("0.12.0.0")] | ||
| [assembly: AssemblyFileVersion("0.12.0.0")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not update the AssemblyVersion here
|
@dsgouda |
|
I understand, we are slowly migrating towards using a generate.ps1 script instead of a cmd. You can do it later if you wish but we are eventually going to get there |
|
@dsgouda |
|
You need to create a |
|
Hi , I have added the generate.ps1 file. could you please review it. Thanks |
|
@v-sodsou looks like the changes to package versions are no longer in the PR, please take a look |
|
@dsgouda |
dsgouda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM subject to builds passing
Description
Azure/azure-rest-api-specs#2884
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.