Convert number lookup ga to preview#42303
Merged
ericasp16 merged 14 commits intoAzure:mainfrom Mar 14, 2024
Merged
Conversation
GA implementation of the number lookup feature. This commit should cover the vast majority of the work needed, and is updated to incorporate feedback from the stewardship board. These changes are going into a branch to wait until we're ready to do our final bug bashing and eventually merging and shipping the feature. --------- * update autorest.md to point to the number lookup feature's latest swagger, update the auto-generated files, and add methods to the public SDK for searching operator information * update generated files based on latest swagger * update changelog for number lookup public preview * update version in PhoneNumbers.csproj * update scripts * fix SMS changelog format * Increment package version after release of Azure.Communication.PhoneNumbers (Azure#38417) * add preview version number * update changelog * update changelog version * run api update script * Increment package version after release of Azure.Communication.PhoneNumbers (Azure#38470) * update generated files * implement GA number lookup updates * updated based on SDK feedback --------- Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
ericasp16
requested review from
KrzysztofCwalina,
RoyHerrod,
danielav7,
miguhern,
tg-msft and
whisper6284
as code owners
guoqing2023
approved these changes
Mar 14, 2024
...ion/Azure.Communication.PhoneNumbers/tests/PhoneNumbersClient/PhoneNumbersClientLiveTests.cs
Show resolved
Hide resolved
angiurgiu
pushed a commit
that referenced
this pull request
Mar 20, 2024
* Number format (#40083) Add number format features to the number lookup public preview. --------- * update autorest.md to point to the number lookup feature's latest swagger, update the auto-generated files, and add methods to the public SDK for searching operator information * update generated files based on latest swagger * update changelog for number lookup public preview * update version in PhoneNumbers.csproj * update scripts * fix SMS changelog format * Increment package version after release of Azure.Communication.PhoneNumbers (#38417) * add preview version number * update changelog * update changelog version * run api update script * Increment package version after release of Azure.Communication.PhoneNumbers (#38470) * update generated files * implement GA number lookup updates * updated based on SDK feedback --------- Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> * update generated files * update to preview * fix serialization of phone numbers in tests * undo unrelated changes to SMS Changelog * update generated files * update generated files * update test files, disable tests that are hanging * update tests, run Export-API * update tests and recordings to include all Number lookup tests --------- Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.