Skip to content

Partner APIs for Express Route with fixes#4229

Merged
dsgouda merged 3 commits intoAzure:psSdkJson6from
vinayada1:partnerapis-publish
Apr 17, 2018
Merged

Partner APIs for Express Route with fixes#4229
dsgouda merged 3 commits intoAzure:psSdkJson6from
vinayada1:partnerapis-publish

Conversation

@vinayada1
Copy link
Contributor

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinayada1 I don't see the related spec updates to make these properties read/write
Please provide spec PR link

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinayada1 does not look like you have generated this code using generate.ps1/generate.cmd scripts
Also, this looks like an additive change to the SDK, please bump the package version to 18.0.1-preview

@vinayada1
Copy link
Contributor Author

Swagger PR: Azure/azure-rest-api-specs#2795
@dsgouda : I did generate the code using generate.cmd since my swagger is checked in. Do you see any issues? Will update the package version

@vinayada1 vinayada1 closed this Apr 17, 2018
@vinayada1 vinayada1 reopened this Apr 17, 2018
@vinayada1
Copy link
Contributor Author

Swagger PR: Azure/azure-rest-api-specs#2795

@dsgouda : I did generate the code using generate.cmd. Do you see any issues? Will update the package version

@dsgouda
Copy link
Contributor

dsgouda commented Apr 17, 2018

@vinayada1 If you generate the code using generate.cmd related information will be logged in a txt file. We can't see that file in this PR.

@vinayada1
Copy link
Contributor Author

@dsgouda Added network_resource-manager.txt file. Sorry.....overlooked that this was a modified file not an untracked file. The diff seemed like not related so had skipped it.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM subject to builds passing.

@dsgouda dsgouda merged commit f61d02b into Azure:psSdkJson6 Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants