Partner APIs for Express Route with fixes#4229
Conversation
There was a problem hiding this comment.
@vinayada1 I don't see the related spec updates to make these properties read/write
Please provide spec PR link
dsgouda
left a comment
There was a problem hiding this comment.
@vinayada1 does not look like you have generated this code using generate.ps1/generate.cmd scripts
Also, this looks like an additive change to the SDK, please bump the package version to 18.0.1-preview
|
Swagger PR: Azure/azure-rest-api-specs#2795 |
|
Swagger PR: Azure/azure-rest-api-specs#2795 @dsgouda : I did generate the code using generate.cmd. Do you see any issues? Will update the package version |
|
@vinayada1 If you generate the code using generate.cmd related information will be logged in a txt file. We can't see that file in this PR. |
|
@dsgouda Added network_resource-manager.txt file. Sorry.....overlooked that this was a modified file not an untracked file. The diff seemed like not related so had skipped it. |
dsgouda
left a comment
There was a problem hiding this comment.
LGTM subject to builds passing.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.