Namespace change for SpellCheck C# SDK by ashku-ms · Pull Request #4219 · Azure/azure-sdk-for-net

ashku-ms · 2018-04-13T01:21:29Z

Description

Keeping in line with the standardization efforts, changing the namespace of C# SDK to the prescribed format Microsoft.Azure.CognitiveServices. The spec was reviewed here

Azure/azure-rest-api-specs#2859

This checklist is used to make sure that common guidelines for a pull request are followed.

Please add REST spec PR link to the SDK PR
I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

dsgouda

Needs version update.

dsgouda · 2018-04-13T16:33:45Z

...Plane/Language/SpellCheck/BingSpellCheck/Microsoft.Azure.CognitiveServices.SpellCheck.csproj

    <Description>This client library provides access to the Microsoft Cognitive Services SpellCheck API.</Description>
-    <VersionPrefix>1.2.0</VersionPrefix>
-    <AssemblyName>Microsoft.Azure.CognitiveServices.SpellCheck</AssemblyName>
+    <VersionPrefix>1.3.0-preview</VersionPrefix>


Changing namespace name is a breaking change. You might want to rev the major version number (2.0.0)
@shahabhijeet FYI

dsgouda · 2018-04-13T18:26:26Z

...Ks/CognitiveServices/dataPlane/Language/SpellCheck/BingSpellCheck/Properties/AssemblyInfo.cs


 [assembly: AssemblyVersion("1.0.0.0")]
-[assembly: AssemblyFileVersion("1.2.0.0")]
+[assembly: AssemblyFileVersion("1.3.0.0")]


Please update version numbers here too

dsgouda · 2018-04-13T20:43:18Z

...Ks/CognitiveServices/dataPlane/Language/SpellCheck/BingSpellCheck/Properties/AssemblyInfo.cs

@@ -8,12 +8,12 @@
 [assembly: AssemblyDescription("Provides API functions for consuming the Microsoft Azure Cognitive Services SpellCheck API.")]

 [assembly: AssemblyVersion("1.0.0.0")]


In case of major version update, AssemblyVersion must also be updated. Apologize for the back and forth

dsgouda

Please create a generate.ps1 file similar to this and regenerate the code
Please run
msbuild build.proj /t:build /p:Scope=SDKs/CognitiveServices/dataPlane/Language/SpellCheck/BingSpellCheck
Please commit any artifacts generated by these commits.

dsgouda · 2018-04-16T22:53:04Z

...Plane/Language/SpellCheck/BingSpellCheck/Microsoft.Azure.CognitiveServices.SpellCheck.csproj

+    <AssemblyName>Microsoft.Azure.CognitiveServices.Language.SpellCheck</AssemblyName>
    <PackageTags>Microsoft Cognitive Services;Cognitive Services;Cognitive Services SDK;SpellCheck API;REST HTTPclient;SpellCheckSDK;netcore451511</PackageTags>
-    <PackageReleaseNotes>This is a public release of the Cognitive Services SpellCheck SDK. Included with this release is support for SpellCheck API.</PackageReleaseNotes>
+    <PackageReleaseNotes>This is a preview release of the Cognitive Services SpellCheck SDK. Included with this release is support for SpellCheck API.</PackageReleaseNotes>


If this is a preview, the package should be versioned as 2.0.0-preview

I updated the generate.cmd file in this directory. Does msbuild build.proj generate the files ? how I run this exactly ? where do i find msbuild and build.proj ?

dsgouda · 2018-04-17T20:52:24Z

@ashku-ms
Please regenerate this code using generate.cmd/generate.ps1 and commit all the files modified/generated.

dsgouda · 2018-04-18T22:13:11Z

src/SDKs/CognitiveServices/dataPlane/Language/SpellCheck/BingSpellCheck/Generate.ps1

@@ -0,0 +1 @@
+powershell.exe -ExecutionPolicy Bypass -NoLogo -NonInteractive -NoProfile -File "..\..\..\..\..\..\..\tools\generateTool.ps1" -ResourceProvider  "cognitiveservices\data-plane\SpellCheck" -PowershellInvoker  -AutoRestVersion "latest"


Replace this with
powershell.exe -ExecutionPolicy Bypass -NoLogo -NonInteractive -NoProfile -File "..\..\..\..\..\..\..\tools\generateTool.ps1" -ResourceProvider "cognitiveservices/data-plane/SpellCheck/BingSpellCheck" -PowershellInvoker -AutoRestVersion "latest"

dsgouda

LGTM

ashku-ms and others added 10 commits November 22, 2017 19:32

Add C# SDK and tests for spellcheck

74584d4

Address review comments

5574848

Merge branch 'psSdkJson6' into psSdkJson6

fcfc4fc

Merge branch 'psSdkJson6' into psSdkJson6

59af489

Merge https://github.com/Azure/azure-sdk-for-net into psSdkJson6

128814f

Move SpellCheck directory to Language directory

b56cc61

Merge branch 'psSdkJson6' into psSdkJson6

4a276e5

Namespace change for Spellcheck API

2a2da5a

Update Csproj file

69b76f6

Merge branch 'psSdkJson6' into NamespaceChange

75e192a

dsgouda suggested changes Apr 13, 2018

View reviewed changes

dsgouda added the Changes Requested label Apr 13, 2018

Update Microsoft.Azure.CognitiveServices.SpellCheck.csproj

d6543d5

dsgouda reviewed Apr 13, 2018

View reviewed changes

Update AssemblyInfo.cs

d5e2975

dsgouda reviewed Apr 13, 2018

View reviewed changes

Update AssemblyInfo.cs

7c5c092

dsgouda suggested changes Apr 16, 2018

View reviewed changes

ashku-ms added 2 commits April 18, 2018 14:41

regenerate using latest autorest

1dae966

update version to public rel

9de9554

dsgouda reviewed Apr 18, 2018

View reviewed changes

dsgouda approved these changes Apr 19, 2018

View reviewed changes

dsgouda removed the Changes Requested label Apr 19, 2018

dsgouda merged commit e6ce594 into Azure:psSdkJson6 Apr 19, 2018

		@@ -8,12 +8,12 @@
		[assembly: AssemblyDescription("Provides API functions for consuming the Microsoft Azure Cognitive Services SpellCheck API.")]

		[assembly: AssemblyVersion("1.0.0.0")]

		@@ -0,0 +1 @@
		powershell.exe -ExecutionPolicy Bypass -NoLogo -NonInteractive -NoProfile -File "..\..\..\..\..\..\..\tools\generateTool.ps1" -ResourceProvider "cognitiveservices\data-plane\SpellCheck" -PowershellInvoker -AutoRestVersion "latest" No newline at end of file

Conversation

ashku-ms commented Apr 13, 2018

Description

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dsgouda commented Apr 17, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants