[Container Instance] update api version 2018-04-01#4207
Merged
dsgouda merged 3 commits intoAzure:psSdkJson6from Apr 11, 2018
yolocs:aci_updates
Merged
[Container Instance] update api version 2018-04-01#4207dsgouda merged 3 commits intoAzure:psSdkJson6from yolocs:aci_updates
dsgouda merged 3 commits intoAzure:psSdkJson6from
yolocs:aci_updates
Conversation
dsgouda
suggested changes
Apr 10, 2018
| <PackageId>ContainerInstance.Tests</PackageId> | ||
| <Description>ContainerInstance.Tests Class Library</Description> | ||
| <AssemblyName>ContainerInstance.Tests</AssemblyName> | ||
| <VersionPrefix>1.0.2-preview</VersionPrefix> |
Contributor
There was a problem hiding this comment.
It is not necessary to modify the version number here. Simply set this to 1.0.0 since these won't be published
| <PropertyGroup> | ||
| <Description>Microsoft Azure Container Instance Management Library</Description> | ||
| <Version>1.0.2-preview</Version> | ||
| <Version>1.0.3</Version> |
Contributor
There was a problem hiding this comment.
Please update the PackageReleaseNotes here
| /// </summary> | ||
| [JsonProperty(PropertyName = "operation")] | ||
| public string Operation { get; set; } | ||
| public string Operation { get; private set; } |
Contributor
There was a problem hiding this comment.
This could potentially be a breaking change for customers. Please bump the package version number to 1.1.0
Contributor
Author
|
All comments addressed. Please take a look. Thanks |
dsgouda
approved these changes
Apr 11, 2018
Contributor
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
LGTM subject to builds passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Azure/azure-rest-api-specs#2778
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.