Skip to content

[Azure Search] Replacing generate.cmd with generate.ps1 and regenerat…#4201

Merged
dsgouda merged 1 commit intoAzure:search-4x-preview-vs17from
brjohnstmsft:generate-ps
Apr 9, 2018
Merged

[Azure Search] Replacing generate.cmd with generate.ps1 and regenerat…#4201
dsgouda merged 1 commit intoAzure:search-4x-preview-vs17from
brjohnstmsft:generate-ps

Conversation

@brjohnstmsft
Copy link
Copy Markdown
Member

@brjohnstmsft brjohnstmsft commented Apr 9, 2018

…ing all code

Description

Per prior PR feedback from @dsgouda, we are replacing generate.cmd with generate.ps1 everywhere. I re-generated all code to test that the new scripts work, and they do. None of the code changed since none of the specs changed in the past few days.

Please note that this PR is targeting a branch that is owned by the Azure Search team.

FYI @natinimni @chaosrealm @mhko @shahabhijeet


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@brjohnstmsft brjohnstmsft requested a review from mhko April 9, 2018 22:49
Copy link
Copy Markdown
Member

@mhko mhko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit d04bc8e into Azure:search-4x-preview-vs17 Apr 9, 2018
@brjohnstmsft brjohnstmsft deleted the generate-ps branch April 9, 2018 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants