Skip to content

Add property in ADF ExecuteSSISPackage activity#4198

Merged
dsgouda merged 5 commits intoAzure:psSdkJson6from
qianwens:psSdkJson6
Apr 11, 2018
Merged

Add property in ADF ExecuteSSISPackage activity#4198
dsgouda merged 5 commits intoAzure:psSdkJson6from
qianwens:psSdkJson6

Conversation

@qianwens
Copy link
Copy Markdown
Member

@qianwens qianwens commented Apr 8, 2018 •
edited
Loading

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@qianwens
Copy link
Copy Markdown
Member Author

qianwens commented Apr 8, 2018

Swagger PR: Azure/azure-rest-api-specs#2716

@qianwens
Copy link
Copy Markdown
Member Author

qianwens commented Apr 9, 2018

@azuresdkci it seems this build is hang in the test step for more than 20 hours, can we restart this build?

@dsgouda dsgouda self-assigned this Apr 9, 2018
dsgouda
dsgouda suggested changes Apr 9, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a generate.ps1 similar to this and regenerate the code.
There are additive changes to the sdk, please rev the csproj version

@qianwens
Copy link
Copy Markdown
Member Author

qianwens commented Apr 10, 2018

@dsgouda there is a generate.cmd file in DataFactory folder which call generate.ps1 as the example. @hvermis should I update the version to 0.7.0-preview in this change?

@dsgouda
Copy link
Copy Markdown
Contributor

dsgouda commented Apr 10, 2018

@qianwens
I did not understand the first question
Since these are additive changes you can simply bump it to 0.6.1-preview

@dsgouda
Copy link
Copy Markdown
Contributor

dsgouda commented Apr 10, 2018

@azuresdkci retest this please

@hvermis
Copy link
Copy Markdown
Contributor

hvermis commented Apr 10, 2018

@qianwens , please add the description of your changes on changelog.md under current version. Please add this to the top of that file and add your own change description below it:

Current version

Feature Additions

hvermis
hvermis requested changes Apr 11, 2018
View reviewed changes
src/SDKs/DataFactory/Management.DataFactory/Microsoft.Azure.Management.DataFactory.csproj Outdated
<PackageId>Microsoft.Azure.Management.DataFactory</PackageId>
<Description>Azure Data Factory V2 is the data integration platform that goes beyond Azure Data Factory V1's orchestration and batch-processing of time-series data, with a general purpose app model supporting modern data warehousing patterns and scenarios, lift-and-shift SSIS, and data-driven SaaS applications. Compose and manage reliable and secure data integration workflows at scale. Use native ADF data connectors and Integration Runtimes to move and transform cloud and on-premises data that can be unstructured, semi-structured, and structured with Hadoop, Azure Data Lake, Spark, SQL Server, Cosmos DB and many other data platforms.</Description>
<Version>0.6.0-preview</Version>
<Version>0.6.1-preview</Version>
Copy link
Copy Markdown
Contributor

@hvermis hvermis Apr 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changes in this file too. I will update all needed files before publishing the nuget.

@qianwens
Copy link
Copy Markdown
Member Author

qianwens commented Apr 11, 2018

@dsgouda I mean there is a generate.cmd file in DataFactory folder already so I think I do not need to create it as you requested. Hermine will update the version before publishing the nuget.

dsgouda
dsgouda approved these changes Apr 11, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the understanding that the package version will be updated prior to publishing

@dsgouda dsgouda merged commit e6f7f64 into Azure:psSdkJson6 Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hvermis hvermis hvermis approved these changes

+1 more reviewer

@dsgouda dsgouda dsgouda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dsgouda dsgouda

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qianwens @dsgouda @hvermis