[Billing RP] Add Enrollment Accounts APIs + tests. by wilcobmsft · Pull Request #4154 · Azure/azure-sdk-for-net

wilcobmsft · 2018-03-21T00:01:08Z

Description

Generating a new Billing SDK based on Azure/azure-rest-api-specs#2626, to add support for enrollment accounts.

This checklist is used to make sure that common guidelines for a pull request are followed.

Please add REST spec PR link to the SDK PR
I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

2. Update existing session records to reflect updated api-version

dsgouda

Please create a generate.ps1 files similar to this and generate the code again using it

dsgouda · 2018-03-21T22:32:30Z

src/SDKs/Billing/Billing.Tests/Properties/AssemblyInfo.cs


-[assembly: AssemblyVersion("2.0.0.0")]
-[assembly: AssemblyFileVersion("2.0.0.0")]
+[assembly: AssemblyVersion("2.1.0.0")]


Please do not update the AssemblyVersion

dsgouda · 2018-03-21T22:33:14Z

src/SDKs/Billing/Management.Billing/Properties/AssemblyInfo.cs


-[assembly: AssemblyVersion("2.0.0.0")]
-[assembly: AssemblyFileVersion("2.0.0.0")]
+[assembly: AssemblyVersion("2.1.0.0")]


Please do not update the AssemblyVersion

dsgouda · 2018-03-21T22:33:43Z

src/SDKs/Billing/Management.Billing/Microsoft.Azure.Management.Billing.csproj

 	<PropertyGroup>
 		<Description>Microsoft Azure Billing Management Library</Description>
-		<Version>2.0.0-preview</Version>
+		<Version>2.1.0-preview</Version>


We highly recommend adding PackageReleaseNotes

dsgouda · 2018-03-21T22:34:52Z

src/SDKs/Billing/Billing.Tests/Billing.Tests.csproj

    <Authors>Microsoft Corporation</Authors>
    <AssemblyName>Billing.Tests</AssemblyName>
-    <VersionPrefix>2.0.0-preview</VersionPrefix>    
+    <VersionPrefix>2.1.0-preview</VersionPrefix>    


You don't need to update the package version for test project since they are never published. Also consider simply setting it to 2.0.0 instead

dsgouda

Still missing the generate.ps1 file

dsgouda · 2018-03-21T22:49:44Z

src/SDKs/Billing/Management.Billing/Generated/Models/ErrorResponseException.cs

        {
        }
-
-#if LEGACY


Was this handwritten code by any chance? Please check if this change was intended

@dsgouda Not handwritten - I ran generated.cmd.

I see that the newer code is generated by generate.cmd. I am concerned about the code that already exists and is being overwritten here.

@dsgouda What options do I have?

@dsgouda This is simply a matter of using a newer version of AutoRest. The current generated code appears to match that of other SDKs.

dsgouda

LGTM

dsgouda · 2018-03-22T20:17:56Z

@wilcobmsft Please generate the code using generate.ps1 and commit the changes

dsgouda

LGTM

wilcobmsft added 3 commits March 20, 2018 11:21

1. Re-generate SDK

ca0fba4

2. Update existing session records to reflect updated api-version

Add enrollment account tests.

52d2e36

Rev version.

da4d98c

dsgouda reviewed Mar 21, 2018

View reviewed changes

dsgouda self-assigned this Mar 21, 2018

dsgouda added the Changes Requested label Mar 21, 2018

Fix versions.

e5ebd01

dsgouda suggested changes Mar 21, 2018

View reviewed changes

Add generate.ps1

563eeae

dsgouda suggested changes Mar 22, 2018

View reviewed changes

Minor test naming fixes.

f04381a

Re-generate using generate.ps1.

5abee42

dsgouda approved these changes Mar 22, 2018

View reviewed changes

dsgouda removed the Changes Requested label Mar 22, 2018

dsgouda merged commit 8043406 into Azure:psSdkJson6 Mar 22, 2018

Conversation

wilcobmsft commented Mar 21, 2018

Description

Generating a new Billing SDK based on Azure/azure-rest-api-specs#2626, to add support for enrollment accounts.

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

dsgouda commented Mar 22, 2018

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants