Update SDK and test for BatchAI for GA#4153
Update SDK and test for BatchAI for GA#4153dsgouda merged 5 commits intoAzure:psSdkJson6from llidev:psSdkJson6
Conversation
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
Looks like you are making some breaking changes here.
Please update the package version number in csproj file
(1.1.0-preview)
Also, please create a generate.ps1 file similar to this and generate the code again using this script
| /// during Create Job. | ||
| /// </summary> | ||
| [JsonProperty(PropertyName = "")] | ||
| [Newtonsoft.Json.JsonIgnore] |
There was a problem hiding this comment.
@shahabhijeet Just want to confirm if this is a breaking change
There was a problem hiding this comment.
This is not a breaking change. They are query parameters not Json properties, this is not by intention for sure, maybe C# swagger generator got enhanced to understand this
|
We need to confirm whether the changes to |
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
Confirmed that the generated code is as expected. Thanks for addressing the comments.
Looks good apart from the minor comment
| <PropertyGroup> | ||
| <PackageId>Microsoft.Azure.Management.BatchAI</PackageId> | ||
| <Description>Provides management capabilities for Azure Batch AI.</Description> | ||
| <Version>1.0.0-preview</Version> |
There was a problem hiding this comment.
Is this meant to be a GA package? If yes, please update the PackageReleaseNotes
There was a problem hiding this comment.
PackageReleaseNotes have been updated
2 participants
Description
Onboarding of .NET SDK for Azure BatchAI Service and related tests for GA. This is being generated by the following spec: https://github.com/Azure/azure-rest-api-specs/tree/master/specification/batchai/resource-manager/Microsoft.BatchAI/stable/2018-03-01
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.