regenerate the sdk since the swagger is updated#4136
regenerate the sdk since the swagger is updated#4136dsgouda merged 7 commits intoAzure:psSdkJson6from
Conversation
shahabhijeet
left a comment
There was a problem hiding this comment.
Please add a link to your swagger spec PR.
Also please pull latest from upstream and use generate.cmd to generate your SDK.
Finally build after generation using
msbuild build.proj /t;build /p:Scope=SDKs\ManagementPartner
this will ensure all the meta data is generated required for the SDK to be merged.
|
@shahabhijeet |
|
@jeffrey-ace in order to publish, you will have to bump up the version as well as add ReleaseNotes. |
|
@shahabhijeet thank you, made the fix. |
|
@jeffrey-ace you have to generate SDK using generate.cmd or generate.ps1 |
|
@jeffrey-ace Please create a |
|
@dsgouda Created the generate.ps1 and run it, but didn't see any new change. can you please take a look? |
|
@jeffrey-ace that was expected, we are moving towards replacing the .cmd file with a .ps1 script without affecting the code generation. |
|
@dsgouda cool, thanks, can you please also approve and merge this PR |
| @@ -0,0 +1 @@ | |||
| powershell.exe -ExecutionPolicy Bypass -NoLogo -NonInteractive -NoProfile -File "$(split-path $SCRIPT:MyInvocation.MyCommand.Path -parent)\..\..\..\..\tools\generateTool.ps1" -ResourceProvider "managementpartner/resource-manager" -SdkDirectory "$(split-path $SCRIPT:MyInvocation.MyCommand.Path -parent)" -PowershellInvoker -AutoRestVersion "latest" No newline at end of file | |||
There was a problem hiding this comment.
@jeffrey-ace Please remove the -SdkDirectory argument here and generate again.
Apologize for the confusion, will fix the example soon.
dsgouda
left a comment
There was a problem hiding this comment.
Thanks @jeffrey-ace LGTM subject to CI builds, will merge on passing.
|
@dsgouda , all checks have passed, can you please merge |
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.