Skip to content

Generating DNS client from latest Swagger changes#4130

Merged
dsgouda merged 1 commit intoAzure:psSdkJson6from
muwaqar:pdns-public-preview
Mar 14, 2018
Merged

Generating DNS client from latest Swagger changes#4130
dsgouda merged 1 commit intoAzure:psSdkJson6from
muwaqar:pdns-public-preview

Conversation

@muwaqar
Copy link
Contributor

@muwaqar muwaqar commented Mar 14, 2018

Description

Generating DNS client from latest Swagger changes (Azure/azure-rest-api-specs#2656). Turns out that there was no code changes required because the previous PR (#4109) included those changes already. So this PR is mainly updating the dns_resource-manager.txt file.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Ran the .cmd command locally to check for diffs but could not find any. Still needs investigation as to why the original PR had all the code generated correctly

@dsgouda dsgouda merged commit 3f99d2a into Azure:psSdkJson6 Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants