Generating DNS client from latest Swagger changes#4130
Merged
dsgouda merged 1 commit intoAzure:psSdkJson6from Mar 14, 2018
muwaqar:pdns-public-preview
Merged
Generating DNS client from latest Swagger changes#4130dsgouda merged 1 commit intoAzure:psSdkJson6from muwaqar:pdns-public-preview
dsgouda merged 1 commit intoAzure:psSdkJson6from
muwaqar:pdns-public-preview
Conversation
dsgouda
approved these changes
Mar 14, 2018
Contributor
dsgouda
left a comment
There was a problem hiding this comment.
LGTM
Ran the .cmd command locally to check for diffs but could not find any. Still needs investigation as to why the original PR had all the code generated correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Generating DNS client from latest Swagger changes (Azure/azure-rest-api-specs#2656). Turns out that there was no code changes required because the previous PR (#4109) included those changes already. So this PR is mainly updating the
dns_resource-manager.txtfile.This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.