Skip to content

feat: initial version of azure developer signing dataplane library#41191

Closed
Jaxelr wants to merge 52 commits intoAzure:mainfrom
Jaxelr:feature/developer-signing-sdk
Closed

feat: initial version of azure developer signing dataplane library#41191
Jaxelr wants to merge 52 commits intoAzure:mainfrom
Jaxelr:feature/developer-signing-sdk

Conversation

@Jaxelr
Copy link
Member

@Jaxelr Jaxelr commented Jan 11, 2024

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

Created using the typespec design created on this pull request

cc: @DawnWang17 @janielMartell

@Jaxelr Jaxelr force-pushed the feature/developer-signing-sdk branch from ad6289d to 79434ea Compare February 27, 2024 15:47
@Jaxelr Jaxelr force-pushed the feature/developer-signing-sdk branch from 79434ea to 2e428e3 Compare March 6, 2024 01:59
@Jaxelr Jaxelr marked this pull request as ready for review March 6, 2024 02:01
@Jaxelr Jaxelr requested review from jsquire and pallavit as code owners March 6, 2024 02:01
@Jaxelr Jaxelr changed the title feat: initial version of azure developer signing library feat: initial version of azure developer signing dataplane library Mar 6, 2024
@jsquire
Copy link
Member

jsquire commented Mar 7, 2024

Service label for Code Signing has been added to the common set and pushed out to all managed repositories. Let's use that when setting up CODEOWNERS.

@Jaxelr Jaxelr requested a review from jsquire March 14, 2024 14:34
@Azure Azure deleted a comment from azure-pipelines bot Mar 14, 2024
@Azure Azure deleted a comment from azure-pipelines bot Mar 14, 2024
@Azure Azure deleted a comment from azure-pipelines bot Mar 14, 2024
@Azure Azure deleted a comment from azure-pipelines bot Mar 14, 2024
@jsquire
Copy link
Member

jsquire commented Mar 14, 2024

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jsquire
Copy link
Member

jsquire commented Mar 14, 2024

@Jaxelr: Your account is missing write permissions to the repository, and we still need a CODEOWNERS entry for this. Instructions and support can be found here:

@jsquire
Copy link
Member

jsquire commented Mar 14, 2024

/azp run net - Azure.Developer.Signing

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Azure Azure deleted a comment from azure-pipelines bot Mar 14, 2024
@jsquire
Copy link
Member

jsquire commented Mar 14, 2024

I overlooked that you're also missing a tests.yml file for use with the live test runs.

@Jaxelr Jaxelr force-pushed the feature/developer-signing-sdk branch from def57bf to 3d1663f Compare March 14, 2024 21:08
@Jaxelr Jaxelr requested a review from ronniegeraghty as a code owner March 14, 2024 21:08
@Jaxelr
Copy link
Member Author

Jaxelr commented Mar 14, 2024

I'm requesting Scott to create a new Team so that my team can join as Service Owners. Thanks for all the feedback.

@Jaxelr
Copy link
Member Author

Jaxelr commented Mar 19, 2024

/azp run net - Azure.Developer.Signing

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Jaxelr
Copy link
Member Author

Jaxelr commented Mar 19, 2024

/azp run net - Azure.Developer.Signing

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Jaxelr
Copy link
Member Author

Jaxelr commented Mar 19, 2024

/azp run net - Azure.Developer.Signing

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@Jaxelr Jaxelr force-pushed the feature/developer-signing-sdk branch from 5059866 to 198d88e Compare September 7, 2024 14:11
@github-actions
Copy link

github-actions bot commented Nov 8, 2024

Hi @Jaxelr. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Nov 8, 2024
@github-actions
Copy link

Hi @Jaxelr. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions bot closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Signing no-recent-activity There has been no recent activity on this issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants