restore point create and delete API#4119
Conversation
jaredmoo
left a comment
There was a problem hiding this comment.
Need test for delete, otherwise looks good :)
There was a problem hiding this comment.
@sarvesh-s please pull from upstream and regenerate using generate.cmd
It has the fix to get you the commit id for your generation
dsgouda
left a comment
There was a problem hiding this comment.
Looks like there are some breaking changes introduced here. Please bump the package version to 1.13.0-preview in the csproj file.
Please pull down the latest changes from upstream and run
msbuild build.proj /t:build /p:Scope=SDKs\SqlManagement
This should update the .props file. Please commit these changes.
|
@sarvesh-s we will do a final review as soon as @jaredmoo approves this PR |
|
@sarvesh-s this PR needs your attention. If you are not able to move forward, I request you to close this PR and open it when it's ready to be reviewed and signed off in due to time by your team. |
|
I updated the PR, now I only have a test change. Rest of the code was already merged as part of different PR, @shahabhijeet |
shahabhijeet
left a comment
There was a problem hiding this comment.
Any idea why
src/SDKs/_metadata/sql_resource-manager.txt
is a binary file in your PR?
|
@jaredmoo Any idea why its binary file shown here as I don't see it locally, its plain text for me |
Then force push to your fork repo |
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.