Skip to content

Update DNS SDK for 2017-10-01 API Version#4113

Closed
nkindberg wants to merge 6 commits intoAzure:psSdkJson6from
nkindberg:psSdkJson6
Closed

Update DNS SDK for 2017-10-01 API Version#4113
nkindberg wants to merge 6 commits intoAzure:psSdkJson6from
nkindberg:psSdkJson6

Conversation

@nkindberg
Copy link
Contributor

@nkindberg nkindberg commented Mar 7, 2018

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@nkindberg
Copy link
Contributor Author

Swagger PR link: Azure/azure-rest-api-specs#2558

@nkindberg
Copy link
Contributor Author

Going to re-submit after making Swagger fixes. Changing location to optional resulted in breaking change which needs to be undone in Swagger.

@nkindberg nkindberg closed this Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant