Skip to content

[Do not merge] Update Azure Batch .Net SDK to meet API version 2018-03-01.6.1.#4111

Closed
xingwu1 wants to merge 7 commits intoAzure:psSdkJson6from
xingwu1:feature/batch-8.1.0
Closed

[Do not merge] Update Azure Batch .Net SDK to meet API version 2018-03-01.6.1.#4111
xingwu1 wants to merge 7 commits intoAzure:psSdkJson6from
xingwu1:feature/batch-8.1.0

Conversation

@xingwu1
Copy link
Member

@xingwu1 xingwu1 commented Mar 6, 2018

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@xingwu1
Copy link
Member Author

xingwu1 commented Mar 6, 2018

The PR of REST API is Azure/azure-rest-api-specs#2556.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run msbuild build.proj /t:build /p:Scope=SDKs\Batch
This should generate a .props file, please commit this file.

@xingwu1
Copy link
Member Author

xingwu1 commented Mar 7, 2018

@dsgouda this is dataplane SDK, should I still need this and named as AzSDK.RP.props?

@dsgouda
Copy link
Contributor

dsgouda commented Mar 7, 2018

Yes, if you see the .props file being generated please commit it.

@xingwu1
Copy link
Member Author

xingwu1 commented Mar 9, 2018

@dsgouda the .props files had been added.

@shahabhijeet
Copy link
Contributor

@xingwu1 couple of things to keep in mind.
When a PR has more than 100 files, it's better you create a PR that has been created after the spec PR is merged.
The current approach you have taken forces us to review your PR now and then again when you will have a generated SDK from the merged spec.
This is acceptable for RPs who are brand new and are going through this process for the first time.

Our SLA is 2 business days and when you are ready to merge your PR we will review it in due time.
This PR will be closed by EOW (please reopen when you are ready with your generated SDK from the merged spec PR)

@shahabhijeet
Copy link
Contributor

@xingwu1 please reopen this PR or create a new PR when spec is merged and new SDK is generated from the merged spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants