Fix recommendation engine APIs along with resource property fixes, add new APIs and tests#4110
Merged
dsgouda merged 7 commits intoAzure:psSdkJson6from Mar 15, 2018
Merged
Conversation
added 4 commits
March 2, 2018 14:37
dsgouda
suggested changes
Mar 7, 2018
Contributor
dsgouda
left a comment
There was a problem hiding this comment.
Please run generate.cmd to generate the code. This should also generate a .txt file, please commit the file.
(If the file is not generate please pull down the latest changes and try again)
Author
|
I ran generate.cmd and a file named src\SDKs_metadata\web_resource_manager.txt was created. Is this what I need to commit? |
Contributor
|
@michimune yes |
Author
|
@dsgouda Pushed the .txt file. |
Contributor
|
@shahabhijeet please merge when ready |
Contributor
|
@michimune There are few more things to be done here
This should update the |
Author
|
@dsgouda Pushed another commit. How does this look? |
Contributor
|
@michimune taking a look |
dsgouda
approved these changes
Mar 8, 2018
Contributor
dsgouda
left a comment
There was a problem hiding this comment.
LGTM @shahabhijeet PTAL and merge
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.