Skip to content

Update recommendation engine APIs along with resource property fix, add new APIs#4101

Closed
michimune wants to merge 5 commits intoAzure:psSdkJson6from
michimune:psSdkJson6
Closed

Update recommendation engine APIs along with resource property fix, add new APIs#4101
michimune wants to merge 5 commits intoAzure:psSdkJson6from
michimune:psSdkJson6

Conversation

@michimune
Copy link

@michimune michimune commented Mar 2, 2018

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Michimune Kohno and others added 2 commits March 2, 2018 14:37
Update recommendation engine APIs and their test
e03d62b
@hitenjava @shahabhijeet
Update Azure Database Migration Service to add Managed Instance as ta…
c3dea7a 
…rget (Azure#4098)

* Update generated files using specs from latest public preview swagger.

* Fix tests.

* Changes:
- Regenerate models to include commit id.
- Update minor version number.

* Add generated AzSdk.RP.props

* Change version number to 0.2.0
dsgouda
dsgouda suggested changes Mar 5, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pull down the latest changes and run:

  • msbuild build.proj /t:build /p:Scope=SDKs\Monitor
    generate.cmd to generate the code
  • These steps should generate the .props and .txt files, you need to commit these files

@dsgouda dsgouda self-assigned this Mar 5, 2018
dsgouda
dsgouda reviewed Mar 5, 2018
View reviewed changes
src/SDKs/WebSites/WebSites.Tests/Properties/AssemblyInfo.cs Outdated

[assembly: AssemblyVersion("2.0.0.0")]
[assembly: AssemblyFileVersion("2.0.0.0")]
[assembly: AssemblyVersion("2.0.0.1")]
Copy link
Contributor

@dsgouda dsgouda Mar 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, the released package version is 1.7.1-preview and the assembly version here is 2.0.0.0 please update the csproj with the new version number 2.0.0-preview and undo these changes in AssemblyInfo.cs.

Copy link
Author

@michimune michimune Mar 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made changes.

dsgouda
dsgouda suggested changes Mar 6, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are two separate projects being modified in this PR Microsoft.DataMigration and Microsoft.Websites. The PR linked in description has changes related to the spec for Microsoft.Websites only, what was the intention behind making changes to two different projects here?

src/SDKs/DataMigration/Management.DataMigration/Properties/AssemblyInfo.cs

[assembly: AssemblyVersion("0.1.2")]
[assembly: AssemblyFileVersion("0.1.2")]
[assembly: AssemblyVersion("0.2.0")]
Copy link
Contributor

@dsgouda dsgouda Mar 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, you don't need to update the assembly version here unless its a major version change.

Copy link
Author

@michimune michimune Mar 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah it was merged when I did git pull from Azure/azure-sdk-for-net. Sorry for confusion.

src/SDKs/WebSites/WebSites.Tests/WebSites.Tests.csproj
<Description>Websites.Tests Class Library</Description>
<AssemblyName>WebSites.Tests</AssemblyName>
<VersionPrefix>1.0.0-preview</VersionPrefix>
<VersionPrefix>2.0.0-preview</VersionPrefix>
Copy link
Contributor

@dsgouda dsgouda Mar 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this is not necessary since we don't publish the tests as such

@dsgouda
Copy link
Contributor

dsgouda commented Mar 6, 2018

@shahabhijeet FYI

@michimune
Copy link
Author

michimune commented Mar 6, 2018

Closing the PR as per discussion with Deepak

@michimune michimune closed this Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dsgouda dsgouda dsgouda requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dsgouda dsgouda

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michimune @dsgouda @hitenjava