Skip to content

EventGrid SDK: Removing the preview suffix from the version #4081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shahabhijeet merged 10 commits into from
Feb 22, 2018
Merged

EventGrid SDK: Removing the preview suffix from the version #4081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
191d62e
Regenerated the SDK and re-recorded the tests based on the newer API …
kalyanaj Jan 13, 2018
cb6162c
Re-recorded the tests.
kalyanaj Jan 13, 2018
17150d1
Updated package release notes to reflect this set of changes.
kalyanaj Jan 17, 2018
f9405e2
Re-recorded the tests.
kalyanaj Jan 17, 2018
0feaea5
Updated the SDK based on the latest data-plane API specifications.
kalyanaj Jan 24, 2018
bb4312d
Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-n…
kalyanaj Jan 24, 2018
080794d
Updated version and release notes.
kalyanaj Jan 24, 2018
2751461
Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-n…
kalyanaj Feb 16, 2018
db475a5
Update package version to 1.3.0 to remove the preview suffix.
kalyanaj Feb 16, 2018
523191a
Fixed a typo in the release notes.
kalyanaj Feb 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
521 changes: 288 additions & 233 deletions ...s/EventGrid.Tests.ScenarioTests.ScenarioTests/EventSubscriptionCreateGetUpdateDelete.json
View file
Open in desktop

Large diffs are not rendered by default.

196 changes: 98 additions & 98 deletions ...cenarioTests.ScenarioTests/EventSubscriptionToAzureSubscriptionCreateGetUpdateDelete.json
View file
Open in desktop

Large diffs are not rendered by default.

322 changes: 216 additions & 106 deletions ...ts.ScenarioTests.ScenarioTests/EventSubscriptionToResourceGroupCreateGetUpdateDelete.json
View file
Open in desktop

Large diffs are not rendered by default.

425 changes: 213 additions & 212 deletions ...essionRecords/EventGrid.Tests.ScenarioTests.ScenarioTests/TopicCreateGetUpdateDelete.json
View file
Open in desktop

Large diffs are not rendered by default.

74 changes: 37 additions & 37 deletions ...Grid.Tests/SessionRecords/EventGrid.Tests.ScenarioTests.ScenarioTests/TopicTypeTests.json
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions ...DKs/EventGrid/management/Management.EventGrid/Microsoft.Azure.Management.EventGrid.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
<PropertyGroup>
<PackageId>Microsoft.Azure.Management.EventGrid</PackageId>
<Description>Provides developers with a library to create and manage all Azure EventGrid resources. </Description>
<Version>1.2.0-preview</Version>
<Version>1.3.0</Version>
<AssemblyName>Microsoft.Azure.Management.EventGrid</AssemblyName>
<PackageTags>Microsoft Azure EventGrid Management;Event Grid;Event Grid management;</PackageTags>
<PackageReleaseNotes>EventSubscriptions.Create() is renamed to EventSubscriptions.CreateOrUpdate(). Also, the SDK is now based on API version 2018-01-01.</PackageReleaseNotes>
<PackageReleaseNotes>Updated the version information to remove the preview suffix.</PackageReleaseNotes>
</PropertyGroup>
<PropertyGroup>
<TargetFrameworks>net452;netstandard1.4</TargetFrameworks>
Expand Down
4 changes: 2 additions & 2 deletions src/SDKs/EventGrid/management/Management.EventGrid/Properties/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
[assembly: AssemblyTitle("Microsoft Azure EventGrid Management Library")]
[assembly: AssemblyDescription("Provides developers with a library to create and manage all Azure EventGrid resources.")]

[assembly: AssemblyVersion("1.2.0.0")]
[assembly: AssemblyFileVersion("1.2.0.0")]
[assembly: AssemblyVersion("1.3.0.0")]
Copy link
Copy Markdown
Contributor

@shahabhijeet shahabhijeet Feb 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kalyanaj starting version 2.0, it is advisable you do not bump up AssemblyVersion for every minor/revision version bump. Unless you have specific reason and you want your developers to take a hand dependency on particular AssemblyVersion.
If you want to do this starting next major version bump, mention it over here and this PR is ready to be merged.

Copy link
Copy Markdown
Contributor Author

@kalyanaj kalyanaj Feb 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks for the info. I will keep this in mind starting the next version update.

[assembly: AssemblyFileVersion("1.3.0.0")]

[assembly: AssemblyConfiguration("")]
[assembly: AssemblyCompany("Microsoft")]
Expand Down