Device Provisioning Service#4050
Merged
shahabhijeet merged 12 commits intoAzure:psSdkJson6from Feb 9, 2018
montgomp:IotHub/DeviceProvisioning
Merged
Device Provisioning Service#4050shahabhijeet merged 12 commits intoAzure:psSdkJson6from montgomp:IotHub/DeviceProvisioning
shahabhijeet merged 12 commits intoAzure:psSdkJson6from
montgomp:IotHub/DeviceProvisioning
Conversation
Can you do the following in the below order: Pull latest from upstream (if you have already done this good) Execute msbuild.exe build.proj from the repo root a. This will update the build tools in the current repo Generate your SDK Build you sdk at least one from command line of IDE a. Msbuild.exe build.proj /t:build /p:Scope=SDKs\ProvisioningServices Update the PR
Contributor
Author
|
@shahabhijeet is it possible to get someone assigned to review this PR? The initial PR was opened mid December and closed due to requested changes to Swagger naming. |
shahabhijeet
suggested changes
Feb 7, 2018
| <Description>Provides management capabilities for Microsoft Azure IoT Device Provisioning Service.</Description> | ||
| <AssemblyTitle>Microsoft Azure Provisioning Service Management</AssemblyTitle> | ||
| <AssemblyName>Microsoft.Azure.Management.DeviceProvisioningServices</AssemblyName> | ||
| <VersionPrefix>0.9.0-preview</VersionPrefix> |
Contributor
There was a problem hiding this comment.
this is < Version > and not < versionPrefix >
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <!-- Please do not move/edit code below this line --> | ||
| <Import Project="$([MSBuild]::GetPathOfFileAbove('AzSdk.reference.props'))" /> | ||
| <!-- Please do not move/edit code below this line --> |
Contributor
There was a problem hiding this comment.
change the type from below this line to above this line
Contributor
Author
There was a problem hiding this comment.
Someone should look into the examples as it seems every project has "below" where it should be "above"
shahabhijeet
suggested changes
Feb 8, 2018
|
|
||
| @echo off | ||
| call %~dp0..\..\..\..\tools\generate.cmd iothub/resource-manager %* | ||
| call %~dp0..\..\..\..\tools\generate.cmd provisioningservices/resource-manager %* |
Contributor
There was a problem hiding this comment.
@montgomp why iotHub has been changed to provisioning services?
Contributor
Author
There was a problem hiding this comment.
Thanks for the catch.
shahabhijeet
approved these changes
Feb 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Re-opening device provisioning service PR due to swagger name changes. https://github.com/Azure/azure-rest-api-specs/tree/master/specification/deviceprovisioningservices/resource-manager
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.