Update [CallerShouldAudit] usage to include classes and interfaces.#40312
Closed
vinodkumarys wants to merge 1 commit intoAzure:mainfrom
Closed
Update [CallerShouldAudit] usage to include classes and interfaces.#40312vinodkumarys wants to merge 1 commit intoAzure:mainfrom
vinodkumarys wants to merge 1 commit intoAzure:mainfrom
Conversation
Collaborator
|
API change check API changes are not detected in this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed with @heaths and @scottaddie, updated the [CallerShouldAudit] attribute usage to include classes and interfaces. Instead of adding the attribute to each individual method in a client class, it would be more beneficial to apply it at the class level. This approach not only offers greater flexibility but also ensures our solution is future-proof, especially as new methods are added to these classes. In scenarios where audit functionality is required only for specific methods, we can still apply the attribute at the individual method level.
Original PR by @tg-msft introducing [CallerShouldAudit] #39345.