Skip to content

Update LinkedIntegrationRuntime properties in data factory#4024

Closed
zhangyd2015 wants to merge 2 commits intoAzure:psSdkJson6from
zhangyd2015:psSdkJson6
Closed

Update LinkedIntegrationRuntime properties in data factory#4024
zhangyd2015 wants to merge 2 commits intoAzure:psSdkJson6from
zhangyd2015:psSdkJson6

Conversation

@zhangyd2015
Copy link
Copy Markdown
Contributor

@zhangyd2015 zhangyd2015 commented Jan 31, 2018

Spec PR 2312

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@shahabhijeet
Copy link
Copy Markdown
Contributor

@zhangyd2015 you have changed 1 file and your commit history has more than 20 commits.
Please clean up your commit history or create a new PR that does not have these merge commits

@zhangyd2015
Copy link
Copy Markdown
Contributor Author

@shahabhijeet Clean up the commit history as your suggestion.

Copy link
Copy Markdown
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhangyd2015 add link to your spec changes.
Also use generate.cmd to generate your code, this PR is missing the metadata file.

@zhangyd2015 zhangyd2015 closed this Feb 3, 2018
@zhangyd2015
Copy link
Copy Markdown
Contributor Author

Will resubmit this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants