Skip to content

Comments

Added support for Autotuning API#4015

Merged
shahabhijeet merged 6 commits intoAzure:psSdkJson6from
kosta-bizetic:autotuning-api
Feb 2, 2018
Merged

Added support for Autotuning API#4015
shahabhijeet merged 6 commits intoAzure:psSdkJson6from
kosta-bizetic:autotuning-api

Conversation

@kosta-bizetic
Copy link
Contributor

@kosta-bizetic kosta-bizetic commented Jan 24, 2018

Description


I generated C# libraries using Autorest for these two APIs:

https://docs.microsoft.com/en-us/rest/api/sql/serverautomatictuning
https://docs.microsoft.com/en-us/rest/api/sql/databaseautomatictuning

and added a test for each API

Swagger specs were already in azure-rest-api-specs. I added them to the corresponding readme.md.

Link to the azure-rest-api-specs PR https://github.com/Azure/azure-rest-api-specs/pull/2325

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

2 similar comments
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@msftclas
Copy link

msftclas commented Jan 24, 2018

CLA assistant check
All CLA requirements met.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

Copy link
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use generate.cmd to generate you SDK
Second build your project as below
msbuild build.proj /t:build /p:Scope=SDKs\SqlManagement
this will create a meta data file that is required (if there are any changes in the API version)

@shahabhijeet
Copy link
Contributor

@kosta-bizetic get onboarded to github by visting aka.ms/azuregithub
This will allow you to get required permisison to kick off CI process.
Also make sure you create an account in travis by visiting travis-ci.org

@kosta-bizetic
Copy link
Contributor Author

kosta-bizetic commented Jan 25, 2018

I have created an account on travis-ci.org so I should have permissions now.

I have built the SDK prior to this PR and even when I build it now using your command I still don't see any meta data file. Where should it appear?

@kosta-bizetic
Copy link
Contributor Author

Here is the link to the new PR for azure-rest-api-specs Azure/azure-rest-api-specs#2332

DesiredState = AutomaticTuningServerMode.Custom,
Options = new Dictionary<string, AutomaticTuningServerOptions>()
{
{"createIndex", new AutomaticTuningServerOptions() {DesiredState=AutomaticTuningOptionModeDesired.On} },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there an enum for these options?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't

@kosta-bizetic
Copy link
Contributor Author

@shahabhijeet can you tell me more about the meta data file?

@shahabhijeet
Copy link
Contributor

@azuresdkci test this please

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

2 similar comments
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@kosta-bizetic
Copy link
Contributor Author

@shahabhijeet
I merged changes from psSdkJson6 into my branch, regenerated and rebuilt the code, and run the tests again. Is the sql_resource-manager.txt from the latest commit the meta data file that should appear?

@shahabhijeet
Copy link
Contributor

@kosta-bizetic I do not see Jenkins job completed for your PR.
Unless Jenkins job is a success, this PR cannot be merged.
Have you onboarded using aka.ms/azuregithub?

@kosta-bizetic
Copy link
Contributor Author

@shahabhijeet All checks have passed. Can the PR be merged now?

@shahabhijeet shahabhijeet merged commit 6691f63 into Azure:psSdkJson6 Feb 2, 2018
@kosta-bizetic kosta-bizetic deleted the autotuning-api branch February 6, 2018 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants