[Storage][DataMovement] Refactor/fix support for CreationPreference#39881
Merged
jalauzon-msft merged 5 commits intoAzure:mainfrom Nov 10, 2023
Merged
[Storage][DataMovement] Refactor/fix support for CreationPreference#39881jalauzon-msft merged 5 commits intoAzure:mainfrom
jalauzon-msft merged 5 commits intoAzure:mainfrom
Conversation
jalauzon-msft
requested review from
amnguye,
jaschrep-msft,
schaabs,
seanmcc-msft and
tg-msft
as code owners
jaschrep-msft
approved these changes
Nov 9, 2023
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
amnguye
approved these changes
Nov 9, 2023
Member
amnguye
left a comment
amnguye
left a comment
There was a problem hiding this comment.
Update the ChangeLog Breaking Changes to include that the values for this enum are changing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change includes a couple of changes to how we handle the
CreationPreferenceoption:StorageResourceCreationPreferenceinstead of just a boolCreationPreferenceto be overridden on resume. This also meant we needed to add a newDefaultoption to the enum