Skip to content

Generated SDK for Connection monitor APIs + tests#3988

Merged
shahabhijeet merged 5 commits intoAzure:psSdkJson6from
irrogozh:psSdkJson6
Jan 11, 2018
Merged

Generated SDK for Connection monitor APIs + tests#3988
shahabhijeet merged 5 commits intoAzure:psSdkJson6from
irrogozh:psSdkJson6

Conversation

@irrogozh
Copy link
Member

@irrogozh irrogozh commented Jan 10, 2018

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please add REST spec PR link to the SDK PR

https://github.com/Azure/azure-rest-api-specs/tree/master/specification/network/resource-manager

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

Azure/azure-rest-api-specs#2223 (review)

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do the following in the below order:

  1. Pull latest from upstream (if you have already done this good)
  2. Execute msbuild.exe build.proj from the repo root
    a. This will update the build tools in the current repo
  3. Generate your SDK using generate.cmd
    a. this creates meta data files that are needed.
  4. Build you sdk at least once from command line of IDE
    a. (From command line use this) Msbuild.exe build.proj /t:build /p:Scope=SDKs\Network
    b. this will create another additional meta data file that is also needed.
  5. Update the PR

<ItemGroup>
<Folder Include="SessionRecords\Network.Tests.Tests.AvailableProvidersListTests\" />
<Folder Include="SessionRecords\Network.Tests.Tests.AzureReachabilityReportTests\" />
<Folder Include="SessionRecords\Network.Tests.Tests.ConnectionMonitorTests\" />
Copy link
Contributor

@shahabhijeet shahabhijeet Jan 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove lines 39-43
you do not need this explicitly, line 24-26 includes all directories

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@shahabhijeet shahabhijeet merged commit 3f53d76 into Azure:psSdkJson6 Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants