Generated SDK for Connection monitor APIs + tests#3988
Merged
shahabhijeet merged 5 commits intoAzure:psSdkJson6from Jan 11, 2018
irrogozh:psSdkJson6
Merged
Generated SDK for Connection monitor APIs + tests#3988shahabhijeet merged 5 commits intoAzure:psSdkJson6from irrogozh:psSdkJson6
shahabhijeet merged 5 commits intoAzure:psSdkJson6from
irrogozh:psSdkJson6
Conversation
shahabhijeet
suggested changes
Jan 10, 2018
Contributor
shahabhijeet
left a comment
There was a problem hiding this comment.
Can you do the following in the below order:
- Pull latest from upstream (if you have already done this good)
- Execute msbuild.exe build.proj from the repo root
a. This will update the build tools in the current repo - Generate your SDK using generate.cmd
a. this creates meta data files that are needed. - Build you sdk at least once from command line of IDE
a. (From command line use this) Msbuild.exe build.proj /t:build /p:Scope=SDKs\Network
b. this will create another additional meta data file that is also needed. - Update the PR
shahabhijeet
suggested changes
Jan 11, 2018
| <ItemGroup> | ||
| <Folder Include="SessionRecords\Network.Tests.Tests.AvailableProvidersListTests\" /> | ||
| <Folder Include="SessionRecords\Network.Tests.Tests.AzureReachabilityReportTests\" /> | ||
| <Folder Include="SessionRecords\Network.Tests.Tests.ConnectionMonitorTests\" /> |
Contributor
There was a problem hiding this comment.
remove lines 39-43
you do not need this explicitly, line 24-26 includes all directories
shahabhijeet
approved these changes
Jan 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
https://github.com/Azure/azure-rest-api-specs/tree/master/specification/network/resource-manager
General Guidelines
Testing Guidelines
SDK Generation Guidelines
Azure/azure-rest-api-specs#2223 (review)
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.