Skip to content

WAM silent SSO using the signed in windows account #39607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 23, 2024
Merged

WAM silent SSO using the signed in windows account #39607

merged 6 commits into from
Jan 23, 2024

Conversation

@christothes
Copy link
Member

@christothes christothes commented Oct 30, 2023 •
edited
Loading

closes #39222

@christothes christothes changed the title POC for WAM SSO POC for WAM silent SSO using the signed in windows account Oct 30, 2023
@christothes christothes mentioned this pull request Nov 7, 2023
Closed
@github-actions
Copy link

github-actions bot commented Jan 5, 2024

Hi @christothes. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels Jan 5, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 19, 2024 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Identity
Azure.Identity.Broker

@christothes christothes changed the title POC for WAM silent SSO using the signed in windows account WAM silent SSO using the signed in windows account Jan 22, 2024
@christothes christothes marked this pull request as ready for review January 22, 2024 16:41
@xiangyan99
Copy link
Member

xiangyan99 commented Jan 22, 2024

It is not supported in other languages MSAL library.

Do we want to make it available only in .net?

@christothes
Copy link
Member Author

christothes commented Jan 22, 2024

It is not supported in other languages MSAL library.

Do we want to make it available only in .net?

We should raise this question of supporting the equivalent of PublicClientApplication.OperatingSystemAccount to MSAL.

@christothes christothes merged commit 910fc04 into Azure:main Jan 23, 2024
@scottaddie scottaddie mentioned this pull request Feb 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heaths heaths heaths approved these changes

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina

@tg-msft tg-msft Awaiting requested review from tg-msft

@schaabs schaabs Awaiting requested review from schaabs

@maorleger maorleger Awaiting requested review from maorleger maorleger is a code owner automatically assigned from Azure/azure-sdk-write-identity

@pvaneck pvaneck Awaiting requested review from pvaneck pvaneck is a code owner automatically assigned from Azure/azure-sdk-write-identity

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner automatically assigned from Azure/azure-sdk-write-identity

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner automatically assigned from Azure/azure-sdk-write-identity

@chlowell chlowell Awaiting requested review from chlowell chlowell is a code owner automatically assigned from Azure/azure-sdk-write-identity

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner automatically assigned from Azure/azure-sdk-write-identity

@JoshLove-msft JoshLove-msft Awaiting requested review from JoshLove-msft

@annelo-msft annelo-msft Awaiting requested review from annelo-msft

@jsquire jsquire Awaiting requested review from jsquire jsquire is a code owner

@pallavit pallavit Awaiting requested review from pallavit

@m-nash m-nash Awaiting requested review from m-nash

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

Assignees

No one assigned

Labels

Azure.Identity

Projects

Azure Identity SDK Improvements
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

WAM sign in should default to the currently signed in windows account, if no account is already in cache

4 participants

@christothes @azure-sdk @xiangyan99 @heaths