Updating .net sdk from latest api version #3932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahabhijeet
suggested changes
Dec 10, 2017
Contributor
Author
|
Pulled latest from upstream, it is already up to date. Regenerated code which generated 2 more files. Checking them in. |
shahabhijeet
suggested changes
Dec 11, 2017
| [assembly: AssemblyVersion("4.0.0.0")] | ||
| [assembly: AssemblyFileVersion("4.3.0.0")] | ||
| //[assembly: AssemblyVersion("4.0.0.0")] | ||
| //[assembly: AssemblyFileVersion("4.3.0.0")] |
Contributor
There was a problem hiding this comment.
@SiddharthChatrolaMs any reason these attributes are commented.
If you have not pulled latest from upstream, please do and also run the following from the root
msbuild build.proj (this will pull the latest build tools)
then do
msbuild build.proj /t:Build /p:Scope=SDKs\RedisCache
this will ensure two things:
- the duplicate attribute errors will be gone
- will update the package meta data for API version for your nuget package.
| <Version>4.4.0</Version> | ||
| <AssemblyName>Microsoft.Azure.Management.Redis</AssemblyName> | ||
| <PackageTags>Microsoft Azure Redis Cache management;Redis Management;</PackageTags> | ||
| <PackageReleaseNotes/> |
Contributor
There was a problem hiding this comment.
Missing package release notes for this release. If this release has lot of new features, this will be a good time to document all those new features in the release, so that users see what is included in the nuget package.
shahabhijeet
approved these changes
Dec 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.