Skip to content

Conversation

@hvermis
Copy link
Contributor

@hvermis hvermis commented Nov 22, 2017

Description


Adding additionalProperties to some of the types to support round-tripping new properties to the service.
Swagger PR Azure/azure-rest-api-specs#2033

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@hvermis
Copy link
Contributor Author

hvermis commented Nov 22, 2017

I have tried testing it local private version of ClientRuntime. While the deserialization worked for additional properties - new property made it to the AdditionProperties with its name as key and value as value, but it did not get serialized back into json. It could be either because of serialization settings or there is another bug in ClientRuntime. Will follow up with the Azure SDK dev team.

@shahabhijeet shahabhijeet merged commit 9a9e389 into Azure:psSdkJson6 Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants