[DataFactory] Adding additionalProperties to roundtrip new properties#3880
Closed
hvermis wants to merge 3 commits intoAzure:psSdkJson6from
hvermis:psSdkJson6
Closed
[DataFactory] Adding additionalProperties to roundtrip new properties#3880hvermis wants to merge 3 commits intoAzure:psSdkJson6from hvermis:psSdkJson6
hvermis wants to merge 3 commits intoAzure:psSdkJson6from
hvermis:psSdkJson6
Conversation
Contributor
Author
|
Swagger PR: |
Contributor
Author
|
I have tried testing it local private version of ClientRuntime. While the deserialization worked for additional properties - new property made it to the AdditionProperties with its name as key and value as value, but it did not get serialized back into json. It could be either because of serialization settings or there is another bug in ClientRuntime. Will follow up with the Azure SDK dev team. |
Contributor
Author
|
Will create new as I had merge problems |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding additionalProperties to some of the types to support round-tripping new properties to the service. The PR also contains changes from other people that were not merged yet. Those are the new sources for Copy activity.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.