Skip to content

Adding [EditorBrowsable(EditorBrowsableState.Never)] for storage scal… #38686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alrod merged 2 commits into from
Sep 18, 2023
Merged

Adding [EditorBrowsable(EditorBrowsableState.Never)] for storage scal… #38686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47ac4c9
Adding [EditorBrowsable(EditorBrowsableState.Never)] for storage scal…
alrod Sep 13, 2023
a99cf34
Updating apis files
alrod Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...ions.Storage.Blobs/api/Microsoft.Azure.WebJobs.Extensions.Storage.Blobs.netstandard2.0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,5 +54,7 @@ namespace Microsoft.Extensions.Hosting
public static partial class StorageBlobsWebJobsBuilderExtensions
{
public static Microsoft.Azure.WebJobs.IWebJobsBuilder AddAzureStorageBlobs(this Microsoft.Azure.WebJobs.IWebJobsBuilder builder, System.Action<Microsoft.Azure.WebJobs.Host.BlobsOptions> configureBlobs = null) { throw null; }
[System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
public static Microsoft.Azure.WebJobs.IWebJobsBuilder AddAzureStorageBlobsScaleForTrigger(this Microsoft.Azure.WebJobs.IWebJobsBuilder builder, Microsoft.Azure.WebJobs.Host.Scale.TriggerMetadata triggerMetadata) { throw null; }
}
}
1 change: 0 additions & 1 deletion ...Jobs.Extensions.Storage.Blobs/src/Microsoft.Azure.WebJobs.Extensions.Storage.Blobs.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
<Version>5.3.0-beta.1</Version>
<!--The ApiCompatVersion is managed automatically and should not generally be modified manually.-->
<ApiCompatVersion>5.2.0</ApiCompatVersion>
<RunApiCompat>false</RunApiCompat>
<Description>This extension adds bindings for Storage</Description>
<!-- https://github.com/Azure/azure-sdk-for-net/issues/19222 -->
<NoWarn>$(NoWarn);IDT002;IDT003</NoWarn>
Expand Down
4 changes: 3 additions & 1 deletion ...rosoft.Azure.WebJobs.Extensions.Storage.Blobs/src/StorageBlobsWebJobsBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Licensed under the MIT License.

using System;
using System.ComponentModel;
using Microsoft.Azure.WebJobs;
using Microsoft.Azure.WebJobs.Extensions.EventGrid;
using Microsoft.Azure.WebJobs.Extensions.Storage.Blobs;
Expand Down Expand Up @@ -71,7 +72,8 @@ public static IWebJobsBuilder AddAzureStorageBlobs(this IWebJobsBuilder builder,
/// <param name="builder"></param>
/// <param name="triggerMetadata">Trigger metadata.</param>
/// <returns></returns>
internal static IWebJobsBuilder AddAzureStorageBlobsScaleForTrigger(this IWebJobsBuilder builder, TriggerMetadata triggerMetadata)
[EditorBrowsable(EditorBrowsableState.Never)]
public static IWebJobsBuilder AddAzureStorageBlobsScaleForTrigger(this IWebJobsBuilder builder, TriggerMetadata triggerMetadata)
{
builder.Services.AddSingleton<IScaleMonitorProvider>(serviceProvider =>
{
Expand Down
1 change: 1 addition & 0 deletions ...ns.Storage.Queues/api/Microsoft.Azure.WebJobs.Extensions.Storage.Queues.netstandard2.0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ namespace Microsoft.Extensions.Hosting
public static partial class StorageQueuesWebJobsBuilderExtensions
{
public static Microsoft.Azure.WebJobs.IWebJobsBuilder AddAzureStorageQueues(this Microsoft.Azure.WebJobs.IWebJobsBuilder builder, System.Action<Microsoft.Azure.WebJobs.Host.QueuesOptions> configureQueues = null) { throw null; }
[System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
public static Microsoft.Azure.WebJobs.IWebJobsBuilder AddAzureStorageQueuesScaleForTrigger(this Microsoft.Azure.WebJobs.IWebJobsBuilder builder, Microsoft.Azure.WebJobs.Host.Scale.TriggerMetadata triggerMetadata) { throw null; }
}
}
2 changes: 2 additions & 0 deletions ...soft.Azure.WebJobs.Extensions.Storage.Queues/src/StorageQueuesWebJobsBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Licensed under the MIT License.

using System;
using System.ComponentModel;
using Microsoft.Azure.WebJobs;
using Microsoft.Azure.WebJobs.Extensions.Storage.Common;
using Microsoft.Azure.WebJobs.Extensions.Storage.Common.Listeners;
Expand Down Expand Up @@ -72,6 +73,7 @@ public static IWebJobsBuilder AddAzureStorageQueues(this IWebJobsBuilder builder
/// <param name="builder"></param>
/// <param name="triggerMetadata">Trigger metadata.</param>
/// <returns></returns>
[EditorBrowsable(EditorBrowsableState.Never)]
public static IWebJobsBuilder AddAzureStorageQueuesScaleForTrigger(this IWebJobsBuilder builder, TriggerMetadata triggerMetadata)
{
IServiceProvider serviceProvider = null;
Expand Down
4 changes: 1 addition & 3 deletions ...osoft.Azure.WebJobs.Extensions.Storage.Scenario.Tests/tests/BlobScaleHostEndToEndTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public class BlobScaleHostEndToEndTests : LiveTestBase<WebJobsTestEnvironment>

private const string Function1Name = "Function1";

//private string ContainerNameTemaplte1 = "container1%rnd%";
private string ContainerNameTemaplte1 = "container1%rnd%";

private const string BlobConnection1 = "BlobConnection1";

Expand All @@ -44,7 +44,6 @@ public void SetUp()
_blobServiceClient = _fixture.BlobServiceClient;
}

/* TODO: https://github.com/Azure/azure-sdk-for-net/issues/38326 renable test after AddAzureStorageBlobsScaleForTrigger is added back.
[Test]
[TestCase(true, Ignore = "true", IgnoreReason = "The test can take long time.")]
[TestCase(false)]
Expand Down Expand Up @@ -177,7 +176,6 @@ await TestHelpers.Await(async () =>
return scaleStatus.Vote == ScaleVote.None && scaleStatus.FunctionScaleStatuses[Function1Name].Vote == ScaleVote.None;
}, timeout);
}
*/

private void SetRecentWrite(IHost scaleHost, BlobContainerClient blobContainerClient, bool setValue)
{
Expand Down