Skip to content

revert some unexpected sample configuration changes #38619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArcturusZhang merged 6 commits into from
Sep 13, 2023
Merged

revert some unexpected sample configuration changes #38619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4214022
disables sample generation in private dns since it was disabled previ…
ArcturusZhang Sep 12, 2023
d69dd00
fix some config issues
ArcturusZhang Sep 12, 2023
14ad1f2
remove the Samples directory since it is capitalized
ArcturusZhang Sep 12, 2023
d9b7a9c
introduce the sample back
ArcturusZhang Sep 12, 2023
50707fe
revert an unexpected removal
ArcturusZhang Sep 12, 2023
9b7e9e6
fix casing
ArcturusZhang Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions sdk/attestation/Azure.ResourceManager.Attestation/src/autorest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ clear-output-folder: true
sample-gen:
output-folder: $(this-folder)/../samples/Generated
clear-output-folder: true
skipped-operations:
- EligibleChildResources_Get
skip-csproj: true
modelerfour:
flatten-payloads: false
Expand Down
44 changes: 44 additions & 0 deletions ...e.ResourceManager.Authorization/samples/Generated/Samples/Sample_ArmResourceExtensions.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions sdk/dns/Azure.ResourceManager.Dns/src/autorest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ clear-output-folder: true
sample-gen:
output-folder: $(this-folder)/../samples/Generated
clear-output-folder: true
sample: false
skip-csproj: true
modelerfour:
flatten-payloads: false
Expand Down
5 changes: 3 additions & 2 deletions sdk/privatedns/Azure.ResourceManager.PrivateDns/src/autorest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ clear-output-folder: true
sample-gen:
output-folder: $(this-folder)/../samples/Generated
clear-output-folder: true
sample: false
skip-csproj: true
modelerfour:
flatten-payloads: false
Expand All @@ -28,7 +29,7 @@ format-by-name-rules:
'ifMatch': 'etag'
'IPv6Address': 'ip-address'
'IPv4Address': 'ip-address'

acronym-mapping:
CPU: Cpu
CPUs: Cpus
Expand Down Expand Up @@ -59,7 +60,7 @@ acronym-mapping:
SoaRecord: PrivateDnsSoaRecordInfo
SrvRecord: PrivateDnsSrvRecordInfo
TxtRecord: PrivateDnsTxtRecordInfo
ProvisioningState : PrivateDnsProvisioningState
ProvisioningState : PrivateDnsProvisioningState

override-operation-name:
RecordSets_List: GetRecords
Expand Down
2 changes: 1 addition & 1 deletion ...uritydevops/Azure.ResourceManager.SecurityDevOps/Azure.ResourceManager.SecurityDevOps.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Project("{E298A5B7-DDEE-4DDB-ADB5-86437D7668A3}") = "Azure.ResourceManager.Secur
EndProject
Project("{E298A5B7-DDEE-4DDB-ADB5-86437D7668A3}") = "Azure.ResourceManager.SecurityDevOps.Tests", "tests\Azure.ResourceManager.SecurityDevOps.Tests.csproj", "{29307F4D-07DD-433A-BE5A-401689A3B737}"
EndProject
Project("{E298A5B7-DDEE-4DDB-ADB5-86437D7668A3}") = "Azure.ResourceManager.SecurityDevOps.Samples", "Samples\Azure.ResourceManager.SecurityDevOps.Samples.csproj", "{F340C8EB-943B-41CF-B9B3-CB5E5BF339BF}"
Project("{E298A5B7-DDEE-4DDB-ADB5-86437D7668A3}") = "Azure.ResourceManager.SecurityDevOps.Samples", "samples\Azure.ResourceManager.SecurityDevOps.Samples.csproj", "{F340C8EB-943B-41CF-B9B3-CB5E5BF339BF}"
EndProject
Global
GlobalSection(SolutionProperties) = preSolution
Expand Down
2 changes: 1 addition & 1 deletion ...urceManager.SecurityDevOps.Samples.csproj → ...urceManager.SecurityDevOps.Samples.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
Comment thread
ArcturusZhang marked this conversation as resolved.
<Project Sdk="Microsoft.NET.Sdk">
<ItemGroup>
<PackageReference Include="Azure.Identity"/>
<PackageReference Include="NUnit" />
Expand Down
0 .../Sample_AzureDevOpsConnectorCollection.cs → .../Sample_AzureDevOpsConnectorCollection.cs
View file
Open in desktop
File renamed without changes.
0 ...es/Sample_AzureDevOpsConnectorResource.cs → ...es/Sample_AzureDevOpsConnectorResource.cs
View file
Open in desktop
File renamed without changes.
0 ...amples/Sample_AzureDevOpsOrgCollection.cs → ...amples/Sample_AzureDevOpsOrgCollection.cs
View file
Open in desktop
File renamed without changes.
0 .../Samples/Sample_AzureDevOpsOrgResource.cs → .../Samples/Sample_AzureDevOpsOrgResource.cs
View file
Open in desktop
File renamed without changes.
0 ...es/Sample_AzureDevOpsProjectCollection.cs → ...es/Sample_AzureDevOpsProjectCollection.cs
View file
Open in desktop
File renamed without changes.
0 ...ples/Sample_AzureDevOpsProjectResource.cs → ...ples/Sample_AzureDevOpsProjectResource.cs
View file
Open in desktop
File renamed without changes.
0 ...mples/Sample_AzureDevOpsRepoCollection.cs → ...mples/Sample_AzureDevOpsRepoCollection.cs
View file
Open in desktop
File renamed without changes.
0 ...Samples/Sample_AzureDevOpsRepoResource.cs → ...Samples/Sample_AzureDevOpsRepoResource.cs
View file
Open in desktop
File renamed without changes.
0 ...mples/Sample_GitHubConnectorCollection.cs → ...mples/Sample_GitHubConnectorCollection.cs
View file
Open in desktop
File renamed without changes.
0 ...Samples/Sample_GitHubConnectorResource.cs → ...Samples/Sample_GitHubConnectorResource.cs
View file
Open in desktop
File renamed without changes.
0 ...d/Samples/Sample_GitHubOwnerCollection.cs → ...d/Samples/Sample_GitHubOwnerCollection.cs
View file
Open in desktop
File renamed without changes.
0 ...ted/Samples/Sample_GitHubOwnerResource.cs → ...ted/Samples/Sample_GitHubOwnerResource.cs
View file
Open in desktop
File renamed without changes.
0 ...ed/Samples/Sample_GitHubRepoCollection.cs → ...ed/Samples/Sample_GitHubRepoCollection.cs
View file
Open in desktop
File renamed without changes.
0 ...ated/Samples/Sample_GitHubRepoResource.cs → ...ated/Samples/Sample_GitHubRepoResource.cs
View file
Open in desktop
File renamed without changes.