Skip to content

update to use duration format in rename-mapping #38599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RodgeFu wants to merge 1 commit into from
Closed

update to use duration format in rename-mapping #38599

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions sdk/datafactory/Azure.ResourceManager.DataFactory/src/autorest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,9 @@ rename-mapping:
VariableType: PipelineVariableType
WranglingDataFlow: DataFactoryWranglingDataFlowProperties
XmlDataset.typeProperties.location: DataLocation
SelfHostedIntegrationRuntimeStatus.typeProperties.updateDelayOffset: updateDelayOffset | duration
SelfHostedIntegrationRuntimeStatus.typeProperties.localTimeZoneOffset: localTimeZoneOffset | duration
UpdateIntegrationRuntimeRequest.updateDelayOffset: updateDelayOffset | duration
Comment on lines +245 to +247
Copy link
Copy Markdown
Member

@ArcturusZhang ArcturusZhang Sep 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could just do this:

Suggested change
SelfHostedIntegrationRuntimeStatus.typeProperties.updateDelayOffset: updateDelayOffset | duration
SelfHostedIntegrationRuntimeStatus.typeProperties.localTimeZoneOffset: localTimeZoneOffset | duration
UpdateIntegrationRuntimeRequest.updateDelayOffset: updateDelayOffset | duration
SelfHostedIntegrationRuntimeStatus.typeProperties.updateDelayOffset: -|duration
SelfHostedIntegrationRuntimeStatus.typeProperties.localTimeZoneOffset: -|duration
UpdateIntegrationRuntimeRequest.updateDelayOffset: -|duration


prepend-rp-prefix:
- BlobEventsTrigger
Expand Down Expand Up @@ -303,18 +306,12 @@ directive:
- from: datafactory.json
where: $.definitions
transform: >
$.UpdateIntegrationRuntimeRequest.properties.updateDelayOffset['format'] = 'duration';
$.LinkedServiceReference.properties.type['x-ms-enum']['name'] = 'LinkedServiceReferenceType';
# - from: Pipeline.json
# where: $.definitions
# transform: >
# $.PipelineElapsedTimeMetricPolicy.properties.duration['type'] = 'string';
# $.PipelineElapsedTimeMetricPolicy.properties.duration['format'] = 'duration';
- from: IntegrationRuntime.json
where: $.definitions
transform: >
$.SelfHostedIntegrationRuntimeStatusTypeProperties.properties.updateDelayOffset['format'] = 'duration';
$.SelfHostedIntegrationRuntimeStatusTypeProperties.properties.localTimeZoneOffset['format'] = 'duration';
# The definition of userAssignedIdentities is not same as the ManagedServiceIdentity, but the actual json text is same, so remove this property here to normalize with shared ManagedServiceIdentity.
- from: datafactory.json
where: $.definitions
Expand Down