[Storage] Storage Client Options Support Audiences by amnguye · Pull Request #38438 · Azure/azure-sdk-for-net

amnguye · 2023-08-30T23:10:41Z

In order to support the other audiences other than the default storage audience. We've added onto our *ClientOptions.Audience to allow customers to specify audiences.

I've done the initial work only for Blobs so we can review and affirm these changes.

(Currently Files, Queues, and Datalake will break in the pipeline because I had to change a dependency, but once we come to an agreement on Blobs, I will update the rest).

Also let's wait until STG 90 merges first before merging this PR.

schaabs

The approach looks good. I left a couple of comments. Also, does this need to be added to queues and files at the same time? Or would they add this functionality later?

amnguye · 2023-09-06T19:50:08Z

The approach looks good. I left a couple of comments. Also, does this need to be added to queues and files at the same time? Or would they add this functionality later?

I will be doing queues, files and datalake in a bit with this PR since I had to make changes to common storage base package. Just wanted to wait to get a first pass before I pattern match the rest.

…ressed PR commeents

…record tests for files audience tests

…ests

…ult to use

azure-sdk · 2023-09-13T23:59:46Z

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Storage.Blobs
Azure.Storage.Files.Shares
Azure.Storage.Files.DataLake
Azure.Storage.Queues

* Add TraceSpan * Add TraceSpan * version funkiness for diagnostics * Update readme and troubleshooting guide (#38825) * test utilities (#38828) * test utilities * fix usings * [Storage] Storage Client Options Support Audiences (#38438) * Initial work for Blob Clients to support Audience * Export API * Moved BlobAudience to Models; Added Audience support in DataLake; Addressed PR commeents * Added audience support for Shares and Queues; Recorded tests; Cannot record tests for files audience tests * Rerecord failure expected tests * Adding default scope after resource id is set; Recorded Share Files tests * Actually removing /.default from tests and correct order of what default to use * Trying to resolve CI issues with Audience.Equals(string) * Attempt to fix CI issues * Cleanup * Timeout for httpclient for VM metadata service and suppress statsbeat instrumentation (#38801) * timeout for httpclient and suppress instrument * Update AzureMonitorExporterEventSource.cs update EventSource message --------- Co-authored-by: Timothy Mothra <tilee@microsoft.com> * Fix offline storage during network errors (#38832) * Fix offline storage during network errors * fix net462 * changelog * remove TraceSpan types * Fix multiple triggers of the same type adding to DI (#38756) * Fix multiple triggers of the same type adding to DI * Compare with created instance * Enabling ScaleHostEndToEndTest again * Adding a comment * export API * Refactor TryGetHeader on Response * undo KeyVault * backout Personalizer * undo storage * undo web pub sub * Fix naming in AddAzureStorageQueuesScaleForTrigger (#38843) * Add tracing types * renames * Support MaxConcurrentCallsPerSession (#38836) * Storage STG 91 (#38839) * Fix the ValidateInheritance naming test failures (#38844) * update * [RecoveryServicesBackup] Fix LRO issue (#38784) * Add LRO * Update CHANGELOG.md * Update comments * Add regression tests * Update assets.json * update --------- Co-authored-by: Chengming <v-cruan@microsoft.com> Co-authored-by: Wei Hu <huwe@microsoft.com> * Fix the IPAddress serialization issue for Peering (#38824) * Remove Credential * API * refactor * remove net461 target * Update AutoRest C# version to 3.0.0-beta.20230920.1 (#38852) * Update Generator Version 3.0.0-beta.20230920.1 * Update SDK codes * Update SDK codes * Update SDK codes * undo kv * updates * missed fies * Richardcho/cancel add participant (#38794) * update swagger * update swagger * apply swagger updates * update api * Revert "apply swagger updates" This reverts commit 99ebc37. * auto generate * add method * add internal events * update api * update api * update swagger * auto generate * add events * add event processor changes * fix build * update api * update code * update typo * fix typo * add unit tests * remove dupe file * update swagger * fix typo * fix typo * fix test * address PR comments --------- Co-authored-by: root <root@DESKTOP-6GBNLER> * [AzureMonitorDistro] disable test (#38840) * fix test * investigating test... * investigating tests * disable test * IUtf8JsonSerializable * Argument * [AzureMonitorDistro] update OTel ResourceDetectors (#38833) * update ResourceDetectors * changelog * [AzureMonitorExporter] prepare new release. Exporter 1.0.0. Distro beta7 (#38838) * bump version * update Readme * fix date * fix changelog header * prepare Distro * [Storage][DataMovement] Add resource specific checkpoint data classes (#38842) * RawRequestUriBuilder * HttpExtensions - 1 * temp * WIP: HttpPipelineExtensions * WIP: HttpPipelineExtensions * Increment version for monitor releases (#38864) * Increment package version after release of Azure.Monitor.OpenTelemetry.Exporter * Increment package version after release of Azure.Monitor.OpenTelemetry.AspNetCore * PipelineProtocolExtensions * export API * Increment package version after release of Azure.Identity (#38667) * add CreateMessage to pipeline * Add constructor to HttpMessage * API * .NET SDK release changes for dataprotection (#38408) * generating sdk for 2023-05-01 Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> * Addressing breaking change comment Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> * Changes Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> * Handling breaking changes Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> * generating sdk for 2023-05-01 Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> * Addressing breaking change comment Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> * Changes Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> * Handling breaking changes Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> * Updated DataProtectionBackupVaultProperties * resolved breaking changes in ArmDataProtectionBackupModelFactory * Add changelog Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> * fixes Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> * Renaming parameters Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> * Update changelog Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> * Added expected release date Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> * Renamed NamespacedNameResource Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> --------- Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> Co-authored-by: SHASHANK SINGH <shashasingh@microsoft.com> Co-authored-by: Himanshu Agarwal <hiaga@microsoft.com> * fix chainingclassifier * Optional * API * Utf8JsonRequestBody * Update MSAL dependencies to latest (#38866) * STJ type extensions * move generated oai client into this branch * pipeline builder for custom policies * implement Pipeline.Send * make shared source RawRequestUriBuilder still work without new project ref * starting to think about policy * fix --------- Signed-off-by: SHASHANK SINGH <shashasingh@microsoft.com> Co-authored-by: Anne Thompson <annelo@microsoft.com> Co-authored-by: Christopher Scott <chriss@microsoft.com> Co-authored-by: Jocelyn <41338290+jaschrep-msft@users.noreply.github.com> Co-authored-by: Amanda Nguyen <48961492+amnguye@users.noreply.github.com> Co-authored-by: Vishwesh Bankwar <vishweshbankwar@users.noreply.github.com> Co-authored-by: Timothy Mothra <tilee@microsoft.com> Co-authored-by: Alexey Rodionov <alrod@inbox.ru> Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com> Co-authored-by: Sean McCullough <44180881+seanmcc-msft@users.noreply.github.com> Co-authored-by: Arthur Ma <arthurma@microsoft.com> Co-authored-by: Minghao Chen <30464227+HarveyLink@users.noreply.github.com> Co-authored-by: Chengming <v-cruan@microsoft.com> Co-authored-by: Wei Hu <huwe@microsoft.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: richardcho-msft <95773682+richardcho-msft@users.noreply.github.com> Co-authored-by: root <root@DESKTOP-6GBNLER> Co-authored-by: Jacob Lauzon <96087589+jalauzon-msft@users.noreply.github.com> Co-authored-by: Shashank Singh <shashank1306s@gmail.com> Co-authored-by: SHASHANK SINGH <shashasingh@microsoft.com> Co-authored-by: Himanshu Agarwal <hiaga@microsoft.com>

* Initial work for Blob Clients to support Audience * Export API * Moved BlobAudience to Models; Added Audience support in DataLake; Addressed PR commeents * Added audience support for Shares and Queues; Recorded tests; Cannot record tests for files audience tests * Rerecord failure expected tests * Adding default scope after resource id is set; Recorded Share Files tests * Actually removing /.default from tests and correct order of what default to use * Trying to resolve CI issues with Audience.Equals(string) * Attempt to fix CI issues * Cleanup

Initial work for Blob Clients to support Audience

aedf83b

amnguye added the Do Not Merge label Aug 30, 2023

github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Aug 30, 2023

amnguye commented Aug 30, 2023

View reviewed changes

Comment thread sdk/storage/Azure.Storage.Blobs/src/BlobAudience.cs

amnguye commented Aug 30, 2023

View reviewed changes

Comment thread sdk/storage/Azure.Storage.Blobs/src/BlobAudience.cs Outdated

amnguye requested a review from jalauzon-msft August 30, 2023 23:17

Export API

217f30b

schaabs reviewed Sep 6, 2023

View reviewed changes

Comment thread sdk/storage/Azure.Storage.Blobs/src/BlobAudience.cs Outdated

Comment thread sdk/storage/Azure.Storage.Common/src/Shared/StorageClientOptions.cs Outdated

tg-msft reviewed Sep 6, 2023

View reviewed changes

Comment thread sdk/storage/Azure.Storage.Blobs/src/BlobAudience.cs Outdated

amnguye added 3 commits September 7, 2023 15:54

Moved BlobAudience to Models; Added Audience support in DataLake; Add…

63de00f

…ressed PR commeents

Added audience support for Shares and Queues; Recorded tests; Cannot …

0ad1e64

…record tests for files audience tests

Rerecord failure expected tests

7a267fb

amnguye commented Sep 11, 2023

View reviewed changes

Comment thread sdk/storage/Azure.Storage.Blobs/tests/BlobBaseClientTests.cs

amnguye commented Sep 11, 2023

View reviewed changes

Comment thread sdk/storage/Azure.Storage.Files.DataLake/tests/DirectoryClientTests.cs

schaabs reviewed Sep 12, 2023

View reviewed changes

Comment thread sdk/storage/Azure.Storage.Files.Shares/src/Models/ShareAudience.cs Outdated

Adding default scope after resource id is set; Recorded Share Files t…

6a13de4

…ests

amnguye removed the Do Not Merge label Sep 13, 2023

amnguye marked this pull request as ready for review September 13, 2023 21:10

amnguye requested review from KrzysztofCwalina, jaschrep-msft and seanmcc-msft as code owners September 13, 2023 21:10

amnguye added 3 commits September 13, 2023 14:58

Actually removing /.default from tests and correct order of what defa…

9864206

…ult to use

Merge branch 'main' into feature/storage/aad-audience

1c1768c

Trying to resolve CI issues with Audience.Equals(string)

0d43f24

amnguye added 2 commits September 18, 2023 10:12

Merge branch 'main' into feature/storage/aad-audience

4a71620

Attempt to fix CI issues

46c97a2

schaabs approved these changes Sep 19, 2023

View reviewed changes

Comment thread sdk/storage/Azure.Storage.Common/src/Shared/StorageExtensions.cs Outdated

Cleanup

e15e073

amnguye enabled auto-merge (squash) September 19, 2023 18:12

amnguye merged commit 12924f8 into Azure:main Sep 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Storage] Storage Client Options Support Audiences#38438

[Storage] Storage Client Options Support Audiences#38438
amnguye merged 12 commits intoAzure:mainfrom
amnguye:feature/storage/aad-audience

amnguye commented Aug 30, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

schaabs left a comment

Uh oh!

Uh oh!

Uh oh!

amnguye commented Sep 6, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azure-sdk commented Sep 13, 2023 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

amnguye commented Aug 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

schaabs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

amnguye commented Sep 6, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azure-sdk commented Sep 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

amnguye commented Aug 30, 2023 •

edited

Loading

azure-sdk commented Sep 13, 2023 •

edited

Loading