[Storage] Resolving generated code issues#38392
Closed
amnguye wants to merge 2 commits intoAzure:mainfrom
Closed
Conversation
amnguye
requested review from
ArcturusZhang,
ArthurMa1978,
archerzz,
jaschrep-msft,
schaabs,
seanmcc-msft and
tg-msft
as code owners
Collaborator
|
API change check API changes are not detected in this pull request. |
Member
Author
|
Could I get someone to review this for Azure.ResourceManager as well? Looks like it needs everything to be regenerated in order for Verify Generated Code to pass. |
Member
Author
|
@jsquire @JoshLove-msft Any clue to what changes happened and why this happened? We didn't change anything in storage. (I can't speak for ResourceManager, but doesn't look like anything changed there too). I don't think I saw any generator changes in the commit history. |
Member
Member
Author
|
Sounds good! I will just close my PR then! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like an unexpected changed to the generator or something. Had to regenerate the code in storage as the Verify generated code started failing.