{Azure Functions} Nuget package for Azure Functions used in Isolated Process should be mentioned. #38056
{Azure Functions} Nuget package for Azure Functions used in Isolated Process should be mentioned. #38056
Conversation
|
API change check API changes are not detected in this pull request. |
|
@seanmcc-msft @amnguye Could you please review this PR once you get a chance ? Thanks in advance. |
amnguye
left a comment
There was a problem hiding this comment.
I'm not entirely sure this is something we want in our README. I think the point of the README is to give an introduction to the library.. and not a "but if this is your scenario, you want to go here or go there". I think that should be rather put in the getting started guide. Or the introduction to the feature of the azure functions worker, like if this is your scenario, use this, and if it's this use that.
I understand the customer's frustration of "if only this was said exactly here then I wouldn't have gone down the rabbit hole here" however at some point we need to draw the line. It's going to increase to us including all kinds of products to use in our read me.
|
I'm comfortable updating the first line to something like "This extension provides functionality for accessing Azure Storage Blobs in Azure Functions within the process." I think this would ease the customer's ask here while not becoming a one stop shop of a guide map to other Azure Products. |
@amnguye Your suggestions have been incorporated. Could you please review and marge this once you get a chance ? |
Docs: https://learn.microsoft.com/en-us/dotnet/api/overview/azure/microsoft.azure.webjobs.extensions.storage.blobs-readme?view=azure-dotnet
This document should perhaps say at the top that the package is not compatible with Azure Functions used in Isolated Process mode; this can only be used with an in-process Azure Functions app. This will avoid confusion mong our customers.
As the isolated functions use : Microsoft.Azure.Functions.Worker.Extensions.Storage.Blobs NuGet package, version 5.x.
fixes #37957
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.