[AzureMonitorExporter] api feedback (part2)#37993
Closed
TimothyMothra wants to merge 2 commits intomainfrom
Closed
[AzureMonitorExporter] api feedback (part2)#37993TimothyMothra wants to merge 2 commits intomainfrom
TimothyMothra wants to merge 2 commits intomainfrom
Conversation
TimothyMothra
requested review from
cijothomas,
rajkumar-rangaraj,
reyang and
vishweshbankwar
as code owners
github-actions
bot
added
Monitor - Distro
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
Author
|
Superseded by #37996 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Responding to feedback on our public api.
Changes
remove preview service version.
update http link in comments.
Note in the screenshots how the link is displayed.
Screenshots
Before:
After:
TODO