Skip to content

Enable IdenticalDialogsTest and add Recordings #37976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
calvinkwtang merged 1 commit into from
Aug 2, 2023
Merged

Enable IdenticalDialogsTest and add Recordings #37976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions ...tion/Azure.Communication.CallAutomation/tests/CallDialogs/CallDialogAutomatedLiveTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,6 @@ public async Task DifferingConcurrentDialogsTest()
}
}

[Ignore(reason:"Running a StartDialog with a request twice is currently bugged to come up as an update")]
[RecordedTest]
public async Task IdenticalDialogsTest()
{
Expand Down Expand Up @@ -343,11 +342,6 @@ public async Task IdenticalDialogsTest()
dialogResponse = await callDialog.StartDialogAsync(dialogOptions).ConfigureAwait(false);
Assert.AreEqual(StatusCodes.Status201Created, dialogResponse.GetRawResponse().Status);

// wait for DialogStarted event
dialogStartedReceived = await WaitForEvent<DialogStarted>(targetCallConnectionId, TimeSpan.FromSeconds(20));
Assert.NotNull(dialogStartedReceived);
Assert.IsTrue(dialogStartedReceived is DialogStarted);

// stop the dialog
var stopDialogResponse = await callDialog.StopDialogAsync(dialogId).ConfigureAwait(false);
Assert.AreEqual(StatusCodes.Status204NoContent, stopDialogResponse.GetRawResponse().Status);
Expand Down
Loading