[ADLA] - [HOTFIX] - Adding an InnerError property to JobInnerError.cs#3796
Merged
shahabhijeet merged 3 commits intoAzure:adl-hotfix-3-0-2-inner-errorfrom Oct 18, 2017
Conversation
* This affected only ADLA Job
Contributor
|
@azuresdkci test this please |
Contributor
Author
|
@shahabhijeet Please note that I ran the following for both branches (Azure:adl-hotfix-3-0-2-inner-error and ro-joowan:ro-joowan-adl-hotfix-3-0-2-inner-error): git reset --hard 20ceebb |
Contributor
Author
|
@shahabhijeet Did the test fail because of the "git reset" above? |
Contributor
|
@azuresdkci test this please |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swagger repo -- fork of Azure/current: git reset --hard 9556a73: Azure/azure-rest-api-specs@9556a73
This is because this commit is right before Ben's update from version 3.0.1 to version 3.1.0-preview, as shown here: https://github.com/Azure/azure-rest-api-specs/commits/current?before=d8aba4a6092b536a0eec12ca66dbbcc26406136c+280
Code gen based on my Swagger fork: https://github.com/ro-joowan/azure-rest-api-specs/commits/hotfix-inner-error
SDK repo -- fork of Azure/psSdkJson6: git reset --hard 20ceebb
This is because this was the last commit for ADLA version 3.0.1 -- this hotfix version is 3.0.2
Commit-list view: https://github.com/Azure/azure-sdk-for-net/commits/psSdkJson6?after=2ffd522a97aa6f88749d30e22355b6aa928ea3e5+139
This change was approved before in a past PR: [BUG FIX] - Making JobInnerError object recursively defined #3666
Primary change is in here: src\SDKs\DataLake.Analytics\Management.DataLake.Analytics\Generated\Models\JobInnerError.cs
I submitted a separate PR for the changelog update: [ADLA] - Update changelog for version 3.0.2 #3792
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.