Skip to content

draft of applying mgmt sdk analyzers#37954

Closed
archerzz wants to merge 1 commit intoAzure:mainfrom
archerzz:analyzer/mgmt/trial
Closed

draft of applying mgmt sdk analyzers#37954
archerzz wants to merge 1 commit intoAzure:mainfrom
archerzz:analyzer/mgmt/trial

Conversation

@archerzz
Copy link
Copy Markdown
Member

@archerzz archerzz commented Aug 1, 2023

  • proposed way to change eng props to add mgmt sdk analyzers
  • add a example of how to suppress warning

Azure/autorest.csharp#3486 Azure/autorest.csharp#3488

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

- proposed way to change eng props to add mgmt sdk analyzers
- add a example of how to suppress warning

Azure/autorest.csharp#3486
Azure/autorest.csharp#3488
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage("Azure.MgmtSdk.Analyzers", "AZM0020", Justification = "Already GA",
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can suppress analyzer warnings here. The changes should be reviewed and approved.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 6, 2023

Hi @archerzz. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Oct 6, 2023
@github-actions
Copy link
Copy Markdown

Hi @archerzz. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions bot closed this Oct 13, 2023
haiyuazhang pushed a commit to haiyuazhang/azure-sdk-for-net that referenced this pull request Mar 8, 2026
* initial commit (Azure#37884)

* update blob enum (Azure#37888)

* Added Files Swagger (Azure#37955)

* Added Files swagger (Azure#37986)

* Added IncrementalCopyOfEarlierSnapshotNotAllowed blob error code and Deprecated IncrementalCopyOfEarlierVersionSnapshotNotAllowed (Azure#37893)

* Add support for missing SKU Name values (Azure#37954)

* Delete Blob Conditional Tier 101 (Azure#37913)

* Delete Blob Conditional Tier

* un-parameterized

* Added SourceCustomerProvidedKey Request Headers (Azure#37928)

* Cross-Tenant support for Principal Bound Delegation Sas 101 (Azure#38020)

* Added Request body and Response body

* Added changes for Files

* Added chnages for Queues

* removed queues

* Added queues back

* Added ShareErrorCodes (Azure#37984)

* Grouped Source CPK (Azure#39176)

* Removed enum (Azure#39320)

---------

Co-authored-by: Nick Liu <nicliu@microsoft.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-recent-activity There has been no recent activity on this issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant