Skip to content

Autorest Regen Preview to 3.0.0-alpha.20230712.2 by Dapeng Zhang from refs/pull/3373/merge#37553

Closed
azure-sdk wants to merge 8 commits intoAzure:mainfrom
azure-sdk:auto-update-autorest-3.0.0-alpha.20230712.2
Closed

Autorest Regen Preview to 3.0.0-alpha.20230712.2 by Dapeng Zhang from refs/pull/3373/merge#37553
azure-sdk wants to merge 8 commits intoAzure:mainfrom
azure-sdk:auto-update-autorest-3.0.0-alpha.20230712.2

Conversation

@azure-sdk
Copy link
Copy Markdown
Collaborator

@azure-sdk azure-sdk commented Jul 12, 2023

@azure-sdk
Copy link
Copy Markdown
Collaborator Author

azure-sdk commented Jul 12, 2023 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.AI.OpenAI

@jsquire jsquire removed the Open AI label Jul 12, 2023
@ArcturusZhang ArcturusZhang mentioned this pull request Jul 13, 2023
Merged
6 tasks
@ArcturusZhang ArcturusZhang force-pushed the auto-update-autorest-3.0.0-alpha.20230712.2 branch from a754e3b to dcc80f2 Compare July 13, 2023 04:45
ArcturusZhang
ArcturusZhang reviewed Jul 14, 2023
View reviewed changes
sdk/openai/Azure.AI.OpenAI/src/Generated/ChatChoice.cs
public int Index { get; }
/// <summary> The reason that this chat completions choice completed its generated. </summary>
public CompletionsFinishReason FinishReason { get; }
public CompletionsFinishReason? FinishReason { get; }
Copy link
Copy Markdown
Member

@ArcturusZhang ArcturusZhang Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the corresponding typespec definition: https://github.com/Azure/azure-rest-api-specs/blob/982929d15d73166dbb9378e15c88b6e2ae5c4b80/specification/cognitiveservices/OpenAI.Inference/models/chat.completions.tsp#L196
This property is required and nullable, therefore this code change is expected.

Copy link
Copy Markdown
Member

@m-nash m-nash Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joseharriaga does this mean Azure/autorest.csharp#3600 is fixed?

Copy link
Copy Markdown
Member

@m-nash m-nash Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or @ArcturusZhang is this part of the change in 3373?

Copy link
Copy Markdown
Member

@m-nash m-nash Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like 3373 is fixing it, can we add fixes 3600 to the description on that PR

Copy link
Copy Markdown
Member

@ArcturusZhang ArcturusZhang Jul 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes 3373 fixes 3600

@ArcturusZhang
Copy link
Copy Markdown
Member

ArcturusZhang commented Jul 21, 2023

Close in favor of #37768

@ArcturusZhang ArcturusZhang mentioned this pull request Jul 21, 2023
Merged
@azure-sdk azure-sdk deleted the auto-update-autorest-3.0.0-alpha.20230712.2 branch October 19, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArcturusZhang ArcturusZhang ArcturusZhang left review comments

@m-nash m-nash m-nash left review comments

@hallipr hallipr Awaiting requested review from hallipr hallipr will be requested when the pull request is marked ready for review hallipr is a code owner

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard will be requested when the pull request is marked ready for review weshaggard is a code owner

@benbp benbp Awaiting requested review from benbp benbp will be requested when the pull request is marked ready for review benbp is a code owner

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 will be requested when the pull request is marked ready for review ArthurMa1978 is a code owner

@thomasp98296 thomasp98296 Awaiting requested review from thomasp98296 thomasp98296 will be requested when the pull request is marked ready for review thomasp98296 is a code owner

@live1206 live1206 Awaiting requested review from live1206 live1206 will be requested when the pull request is marked ready for review live1206 is a code owner

@wanyang7 wanyang7 Awaiting requested review from wanyang7 wanyang7 will be requested when the pull request is marked ready for review wanyang7 is a code owner

@joseharriaga joseharriaga Awaiting requested review from joseharriaga joseharriaga will be requested when the pull request is marked ready for review joseharriaga is a code owner

@jpalvarezl jpalvarezl Awaiting requested review from jpalvarezl jpalvarezl will be requested when the pull request is marked ready for review jpalvarezl is a code owner

@trrwilson trrwilson Awaiting requested review from trrwilson trrwilson will be requested when the pull request is marked ready for review trrwilson is a code owner

@bojunehsu bojunehsu Awaiting requested review from bojunehsu bojunehsu will be requested when the pull request is marked ready for review bojunehsu is a code owner

@changjian-wang changjian-wang Awaiting requested review from changjian-wang changjian-wang will be requested when the pull request is marked ready for review changjian-wang is a code owner

@jsquire jsquire Awaiting requested review from jsquire jsquire will be requested when the pull request is marked ready for review jsquire is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

Cognitive - Form Recognizer Do Not Merge Mixed Reality Search Synapse

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@azure-sdk @ArcturusZhang @m-nash @jsquire