Skip to content

[Azure.Core] Remove NameHint #37544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nisha-bhatia merged 1 commit into from
Jul 12, 2023
Merged

[Azure.Core] Remove NameHint #37544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion sdk/core/Azure.Core/api/Azure.Core.net461.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1148,7 +1148,6 @@ public partial class ModelSerializerOptions
public ModelSerializerOptions() { }
public bool IgnoreAdditionalProperties { get { throw null; } set { } }
public bool IgnoreReadOnlyProperties { get { throw null; } set { } }
public string? NameHint { get { throw null; } set { } }
public System.Collections.Generic.Dictionary<System.Type, Azure.Core.Serialization.ObjectSerializer> Serializers { get { throw null; } }
}
public abstract partial class ObjectSerializer
Expand Down
1 change: 0 additions & 1 deletion sdk/core/Azure.Core/api/Azure.Core.net5.0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1148,7 +1148,6 @@ public partial class ModelSerializerOptions
public ModelSerializerOptions() { }
public bool IgnoreAdditionalProperties { get { throw null; } set { } }
public bool IgnoreReadOnlyProperties { get { throw null; } set { } }
public string? NameHint { get { throw null; } set { } }
public System.Collections.Generic.Dictionary<System.Type, Azure.Core.Serialization.ObjectSerializer> Serializers { get { throw null; } }
}
public abstract partial class ObjectSerializer
Expand Down
1 change: 0 additions & 1 deletion sdk/core/Azure.Core/api/Azure.Core.net6.0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1148,7 +1148,6 @@ public partial class ModelSerializerOptions
public ModelSerializerOptions() { }
public bool IgnoreAdditionalProperties { get { throw null; } set { } }
public bool IgnoreReadOnlyProperties { get { throw null; } set { } }
public string? NameHint { get { throw null; } set { } }
public System.Collections.Generic.Dictionary<System.Type, Azure.Core.Serialization.ObjectSerializer> Serializers { get { throw null; } }
}
public abstract partial class ObjectSerializer
Expand Down
1 change: 0 additions & 1 deletion sdk/core/Azure.Core/api/Azure.Core.netcoreapp2.1.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1148,7 +1148,6 @@ public partial class ModelSerializerOptions
public ModelSerializerOptions() { }
public bool IgnoreAdditionalProperties { get { throw null; } set { } }
public bool IgnoreReadOnlyProperties { get { throw null; } set { } }
public string? NameHint { get { throw null; } set { } }
public System.Collections.Generic.Dictionary<System.Type, Azure.Core.Serialization.ObjectSerializer> Serializers { get { throw null; } }
}
public abstract partial class ObjectSerializer
Expand Down
1 change: 0 additions & 1 deletion sdk/core/Azure.Core/api/Azure.Core.netstandard2.0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1148,7 +1148,6 @@ public partial class ModelSerializerOptions
public ModelSerializerOptions() { }
public bool IgnoreAdditionalProperties { get { throw null; } set { } }
public bool IgnoreReadOnlyProperties { get { throw null; } set { } }
public string? NameHint { get { throw null; } set { } }
public System.Collections.Generic.Dictionary<System.Type, Azure.Core.Serialization.ObjectSerializer> Serializers { get { throw null; } }
}
public abstract partial class ObjectSerializer
Expand Down
5 changes: 0 additions & 5 deletions sdk/core/Azure.Core/src/Serialization/ModelSerializerOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,5 @@ public class ModelSerializerOptions
/// Dictionary that holds all the serializers for the different model types.
/// </summary>
public Dictionary<Type, ObjectSerializer> Serializers { get; } = new Dictionary<Type, ObjectSerializer>();

/// <summary>
/// NameHint for Xml Models
/// </summary>
public string? NameHint { get; set; }
}
}
3 changes: 1 addition & 2 deletions sdk/core/Azure.Core/tests/public/ModelSerializationTests/Models/ModelXml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,10 @@ public ModelXml(string key, string value, string readonlyProperty)
[XmlElement("ReadOnlyProperty")]
public string ReadOnlyProperty { get; }

void IXmlSerializable.Write(XmlWriter writer, string nameHint) => Serialize(writer, new ModelSerializerOptions() {NameHint = nameHint});
void IXmlSerializable.Write(XmlWriter writer, string nameHint) => Serialize(writer, new ModelSerializerOptions());

private void Serialize(XmlWriter writer, ModelSerializerOptions options)
{
writer.WriteStartElement(options.NameHint ?? "Tag");
writer.WriteStartElement("Key");
writer.WriteValue(Key);
writer.WriteEndElement();
Expand Down
3 changes: 1 addition & 2 deletions ...re/Azure.Core/tests/public/ModelSerializationTests/Models/XmlModelForCombinedInterface.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public XmlModelForCombinedInterface(string key, string value, string readOnlyPro
[XmlElement("ReadOnlyProperty")]
public string ReadOnlyProperty { get; }

void IXmlSerializable.Write(XmlWriter writer, string nameHint) => Serialize(writer, new ModelSerializerOptions() { NameHint = nameHint });
void IXmlSerializable.Write(XmlWriter writer, string nameHint) => Serialize(writer, new ModelSerializerOptions());

internal static XmlModelForCombinedInterface DeserializeXmlModelForCombinedInterface(XElement element, ModelSerializerOptions options = default)
{
Expand All @@ -65,7 +65,6 @@ internal static XmlModelForCombinedInterface DeserializeXmlModelForCombinedInter

private void Serialize(XmlWriter writer, ModelSerializerOptions options)
{
writer.WriteStartElement(options.NameHint ?? "Tag");
writer.WriteStartElement("Key");
writer.WriteValue(Key);
writer.WriteEndElement();
Expand Down