[ACS JobRouter] Minor docstring update + Hide communication error model from RouterSDK

sdk/communication/Azure.Communication.JobRouter/api/Azure.Communication.JobRouter.netstandard2.0.cs

@@ -768,15 +768,6 @@ public partial class CloseJobResult
     {
         internal CloseJobResult() { }
     }
-    public partial class CommunicationError
-    {
-        internal CommunicationError() { }
-        public string Code { get { throw null; } }
-        public System.Collections.Generic.IReadOnlyList<Azure.Communication.JobRouter.Models.CommunicationError> Details { get { throw null; } }
-        public Azure.Communication.JobRouter.Models.CommunicationError InnerError { get { throw null; } }
-        public string Message { get { throw null; } }
-        public string Target { get { throw null; } }
-    }
     public partial class CompleteJobResult
     {
         internal CompleteJobResult() { }
@@ -907,7 +898,6 @@ internal RouterJobPositionDetails() { }
     public static partial class RouterModelFactory
     {
         public static Azure.Communication.JobRouter.Models.AcceptJobOfferResult AcceptJobOfferResult(string assignmentId = null, string jobId = null, string workerId = null) { throw null; }
-        public static Azure.Communication.JobRouter.Models.CommunicationError CommunicationError(string code = null, string message = null, string target = null, System.Collections.Generic.IEnumerable<Azure.Communication.JobRouter.Models.CommunicationError> details = null, Azure.Communication.JobRouter.Models.CommunicationError innerError = null) { throw null; }
         public static Azure.Communication.JobRouter.Models.RouterJobAssignment RouterJobAssignment(string assignmentId = null, string workerId = null, System.DateTimeOffset assignedAt = default(System.DateTimeOffset), System.DateTimeOffset? completedAt = default(System.DateTimeOffset?), System.DateTimeOffset? closedAt = default(System.DateTimeOffset?)) { throw null; }
         public static Azure.Communication.JobRouter.Models.RouterJobOffer RouterJobOffer(string offerId = null, string jobId = null, int capacityCost = 0, System.DateTimeOffset? offeredAt = default(System.DateTimeOffset?), System.DateTimeOffset? expiresAt = default(System.DateTimeOffset?)) { throw null; }
         public static Azure.Communication.JobRouter.Models.RouterQueueItem RouterQueueItem(Azure.Communication.JobRouter.Models.RouterQueue queue = null, string etag = null) { throw null; }

sdk/communication/Azure.Communication.JobRouter/src/Models/CommunicationError.cs

@@ -12,7 +12,7 @@ namespace Azure.Communication.JobRouter.Models
     /// Error model.
     /// </summary>
     [CodeGenModel("CommunicationError")]
-    public partial class CommunicationError
+    internal partial class CommunicationError
     {
     }
 }

sdk/communication/Azure.Communication.JobRouter/src/Models/RouterModelFactory.cs

@@ -1,12 +1,27 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
+using System.Collections.Generic;
+using System.Linq;
 using Azure.Core;
 
 namespace Azure.Communication.JobRouter.Models
 {
     [CodeGenModel("AzureCommunicationServicesModelFactory")]
     public static partial class RouterModelFactory
     {
+        /// <summary> Initializes a new instance of CommunicationError. </summary>
+        /// <param name="code"> The error code. </param>
+        /// <param name="message"> The error message. </param>
+        /// <param name="target"> The error target. </param>
+        /// <param name="details"> Further details about specific errors that led to this error. </param>
+        /// <param name="innerError"> The inner error if any. </param>
+        /// <returns> A new <see cref="Models.CommunicationError"/> instance for mocking. </returns>
+        internal static CommunicationError CommunicationError(string code = null, string message = null, string target = null, IEnumerable<CommunicationError> details = null, CommunicationError innerError = null)
+        {
+            details ??= new List<CommunicationError>();
+
+            return new CommunicationError(code, message, target, details?.ToList(), innerError);
+        }
     }
 }

sdk/communication/Azure.Communication.JobRouter/src/autorest.md

@@ -15,7 +15,7 @@ If any of the new objects needs to be overwritten, add the required changes to t
 tag: package-jobrouter-2022-07-18-preview
 model-namespace: false
 require:
-    -  https://raw.githubusercontent.com/williamzhao87/azure-rest-api-specs/53a603c76359d0102a5b2e85337a14dc441083f6/specification/communication/data-plane/JobRouter/readme.md
+    -  https://raw.githubusercontent.com/williamzhao87/azure-rest-api-specs/c6b35542072b325bfc07c32f5fc05fb5da6891bd/specification/communication/data-plane/JobRouter/readme.md
 
 generation1-convenience-client: true
 reflect-api-versions: true