[Compute] AZ and VMSS rolling upgrade update and tests#3739
Closed
hyonholee wants to merge 6 commits intoAzure:psSdkJson6from
Closed
[Compute] AZ and VMSS rolling upgrade update and tests#3739hyonholee wants to merge 6 commits intoAzure:psSdkJson6from
hyonholee wants to merge 6 commits intoAzure:psSdkJson6from
Conversation
…tests for AZ, VMSS rolling upgrade
f0c98cb to
2ea7fc5
Compare
markcowl
requested changes
Sep 26, 2017
Member
markcowl
left a comment
There was a problem hiding this comment.
Also, can you update the generate.cmd and include the metadata file that is generated when you runit?
| @@ -0,0 +1,185 @@ | |||
| Param( | |||
shahabhijeet
suggested changes
Oct 5, 2017
Contributor
shahabhijeet
left a comment
There was a problem hiding this comment.
Provide a clear description that describes the reason for the PR. Explain the change in detail.
Failing to do this, will result in PR not being reviewed.
This is a public repo and every PR should be clearly explained as to what the PR is all about.
Contributor
|
@hyonholee pleaes reopen the same PR once you have addressed all feedback/questions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure/azure-rest-api-specs#1727
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.