Skip to content

[Compute] AZ and VMSS rolling upgrade update and tests#3739

Closed
hyonholee wants to merge 6 commits intoAzure:psSdkJson6from
hyonholee:psSdkJson6
Closed

[Compute] AZ and VMSS rolling upgrade update and tests#3739
hyonholee wants to merge 6 commits intoAzure:psSdkJson6from
hyonholee:psSdkJson6

Conversation

@hyonholee
Copy link
Copy Markdown
Contributor

@hyonholee hyonholee commented Sep 23, 2017

Azure/azure-rest-api-specs#1727

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Copy Markdown
Member

@markcowl markcowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can you update the generate.cmd and include the metadata file that is generated when you runit?

@@ -0,0 +1,185 @@
Param(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this in the repo?

Copy link
Copy Markdown
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide a clear description that describes the reason for the PR. Explain the change in detail.
Failing to do this, will result in PR not being reviewed.
This is a public repo and every PR should be clearly explained as to what the PR is all about.

@shahabhijeet
Copy link
Copy Markdown
Contributor

@hyonholee pleaes reopen the same PR once you have addressed all feedback/questions.
Having a PR open for more than a week affects our SLA data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants