Skip to content

Update changelog.md for Nuget package release#37222

Merged
ArthurMa1978 merged 2 commits intoAzure:mainfrom
mwesigwaguma:publish_nuget
Jun 29, 2023
Merged

Update changelog.md for Nuget package release#37222
ArthurMa1978 merged 2 commits intoAzure:mainfrom
mwesigwaguma:publish_nuget

Conversation

@mwesigwaguma
Copy link
Copy Markdown
Contributor

@mwesigwaguma mwesigwaguma commented Jun 26, 2023 •
edited
Loading

Related Pull request: #36990

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Jun 26, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 26, 2023

Thank you for your contribution @mwesigwaguma! We will review the pull request and get back to you soon.

@azure-sdk
Copy link
Copy Markdown
Collaborator

azure-sdk commented Jun 26, 2023

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.ResourceManager.ServiceFabricManagedClusters

@mwesigwaguma
Copy link
Copy Markdown
Contributor Author

mwesigwaguma commented Jun 28, 2023 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.ResourceManager.ServiceFabricManagedClusters

Hey @ArthurMa1978 is the word 'beta' needed in the version name ? it was automatically generated but I would like to change it to just 1.1.0.0. Also this is the version they here: https://apiview.dev/Assemblies/Review/582a13da375d4a5dbbac94141a03db12#
Also, it looks like merging is still blocked.

@ArthurMa1978
Copy link
Copy Markdown
Member

ArthurMa1978 commented Jun 29, 2023

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.ResourceManager.ServiceFabricManagedClusters

Hey @ArthurMa1978 Arthur Ma FTE is the word 'beta' needed in the version name ? it was automatically generated but I would like to change it to just 1.1.0.0. Also this is the version they here: https://apiview.dev/Assemblies/Review/582a13da375d4a5dbbac94141a03db12# Also, it looks like merging is still blocked.

Here is the versioning policy https://azure.github.io/azure-sdk/policies_releases.html#net

@ArthurMa1978 ArthurMa1978 merged commit 71a7b74 into Azure:main Jun 29, 2023
@ArthurMa1978 ArthurMa1978 added the Mgmt This issue is related to a management package. label Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a-santamaria a-santamaria a-santamaria approved these changes

@ArthurMa1978 ArthurMa1978 ArthurMa1978 approved these changes

@archerzz archerzz Awaiting requested review from archerzz

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang ArcturusZhang is a code owner

Assignees

@m-nash m-nash

Labels

Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management package.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mwesigwaguma @azure-sdk @ArthurMa1978 @a-santamaria @m-nash