Skip to content

[Storage] rename SKUs to Skus#3682

Merged
shahabhijeet merged 2 commits intoAzure:psSdkJson6from
JasonYang-MSFT:renameskus
Sep 13, 2017
Merged

[Storage] rename SKUs to Skus#3682
shahabhijeet merged 2 commits intoAzure:psSdkJson6from
JasonYang-MSFT:renameskus

Conversation

@JasonYang-MSFT
Copy link
Copy Markdown
Member

@JasonYang-MSFT JasonYang-MSFT commented Sep 12, 2017

Description

Fixed bad names in swagger for python SDK, which affect other SDKs.
Since 7.0.0 haven't released yet, this will not break current experience for customers.

Azure/azure-rest-api-specs#1650


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Copy Markdown
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add < PackageReleaseNotes > and add Release notes in .csproj. This helps in knowing what is included in the nuget package.
I would recommend to use < ![CDATA and then format your Release notes

@JasonYang-MSFT
Copy link
Copy Markdown
Member Author

Changelog added, it should be available once this pr is merged.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property has to be part of a propertygroup

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@shahabhijeet shahabhijeet merged commit 198930f into Azure:psSdkJson6 Sep 13, 2017
JasonYang-MSFT added a commit to JasonYang-MSFT/azure-sdk-for-net that referenced this pull request Dec 8, 2017
* [Storage] rename SKUs to Skus

* [Storage] added changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants