Update Batch to use latest AutoRest, remove PORTABLE flag in build#3679
Merged
shahabhijeet merged 2 commits intoAzure:psSdkJson6from Sep 12, 2017
Merged
Update Batch to use latest AutoRest, remove PORTABLE flag in build#3679shahabhijeet merged 2 commits intoAzure:psSdkJson6from
shahabhijeet merged 2 commits intoAzure:psSdkJson6from
Conversation
- There is currently a bug Azure/autorest#2558 which had to be worked around with a hacky script fix, in fixup.ps1. Once that issue is fixed we should remove fixup.ps1.
Member
Author
|
@shahabhijeet this resolves issue #3139 |
Contributor
|
@matthchr can you update the description and also link to spec if applicable. |
Contributor
|
I don't see any version bump, is this update is not ready to be published? |
Member
Author
|
No, we aren't going to publish this yet. We have an upcoming release and we will release this with that. |
Contributor
please add < PackageReleaseNotes > and add Release notes. Refers to: src/SDKs/Batch/DataPlane/Azure.Batch/Azure.Batch.csproj:11 in 5d45c34. [](commit_id = 5d45c34, deletion_comment = False) |
Member
Author
|
We have |
JasonYang-MSFT
pushed a commit
to JasonYang-MSFT/azure-sdk-for-net
that referenced
this pull request
Dec 8, 2017
…zure#3679) * Update to latest version of AutoRest code generator - There is currently a bug Azure/autorest#2558 which had to be worked around with a hacky script fix, in fixup.ps1. Once that issue is fixed we should remove fixup.ps1. * Remove PORTABLE from Batch.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.