Skip to content

Update Batch to use latest AutoRest, remove PORTABLE flag in build#3679

Merged
shahabhijeet merged 2 commits intoAzure:psSdkJson6from
matthchr:feature/update-autorest
Sep 12, 2017
Merged

Update Batch to use latest AutoRest, remove PORTABLE flag in build#3679
shahabhijeet merged 2 commits intoAzure:psSdkJson6from
matthchr:feature/update-autorest

Conversation

@matthchr
Copy link
Copy Markdown
Member

@matthchr matthchr commented Sep 8, 2017

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

  - There is currently a bug Azure/autorest#2558 which had to be worked around
    with a hacky script fix, in fixup.ps1. Once that issue is fixed we should remove fixup.ps1.
@matthchr
Copy link
Copy Markdown
Member Author

matthchr commented Sep 8, 2017

@shahabhijeet this resolves issue #3139

@shahabhijeet
Copy link
Copy Markdown
Contributor

@matthchr can you update the description and also link to spec if applicable.

@shahabhijeet
Copy link
Copy Markdown
Contributor

I don't see any version bump, is this update is not ready to be published?

@matthchr
Copy link
Copy Markdown
Member Author

No, we aren't going to publish this yet. We have an upcoming release and we will release this with that.

@shahabhijeet
Copy link
Copy Markdown
Contributor

<DocumentationFile>bin\$(Configuration)\$(TargetFramework)\$(AssemblyName).xml</DocumentationFile>

please add < PackageReleaseNotes > and add Release notes.
I would recommend to use < ![CDATA and then format your Release notes


Refers to: src/SDKs/Batch/DataPlane/Azure.Batch/Azure.Batch.csproj:11 in 5d45c34. [](commit_id = 5d45c34, deletion_comment = False)

@matthchr
Copy link
Copy Markdown
Member Author

We have <PackageReleaseNotes>For detailed release notes, see: https://aka.ms/batch-net-dataplane-changelog</PackageReleaseNotes> already, on line 17. Did you miss it?

@shahabhijeet shahabhijeet merged commit 0927ef8 into Azure:psSdkJson6 Sep 12, 2017
@matthchr matthchr deleted the feature/update-autorest branch September 12, 2017 21:06
JasonYang-MSFT pushed a commit to JasonYang-MSFT/azure-sdk-for-net that referenced this pull request Dec 8, 2017
…zure#3679)

* Update to latest version of AutoRest code generator

  - There is currently a bug Azure/autorest#2558 which had to be worked around
    with a hacky script fix, in fixup.ps1. Once that issue is fixed we should remove fixup.ps1.

* Remove PORTABLE from Batch.csproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants