Resolve architect feedback #36637
Merged
Resolve architect feedback #36637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves Azure#36514
heaths
added
the
late-blocker
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
kristapratico
approved these changes
May 30, 2023
abhinav-ghai
pushed a commit
that referenced
this pull request
Jun 1, 2023
* Initial generation * Fix double line break, add API version to rest client options * Generate API * add old versions back in to fix build * creation of new test resources and updated test recordings * new bulk tests skeleton * update/add test for import api * move new test variables into service specific config file * fixing tests and updated rest api spec commit id * final testing changes * serialize entire exception in the case of test failure * initial job lifecycle sample code * add code to upload input blob to storage container for quickstart sample * updates to quickstart sample * Updated code to latest api version * Updated samples for clarity * fixed build errors * Add separate meterprovider for standard metrics (#36369) * Add separate meterprovider for standard metrics * assert cloud role name value * remove unnecessary using * Remove defunct template (#36543) Co-authored-by: James Suplizio <[email protected]> * [ACS JobRouter] Protocol methods for merge-patch support to remove properties (#36513) * protocol methods for merge-patch support to remove properties * address review feedback * Change foreach loop to use ref readonly for tag/event/link enumeration (#36544) * Increment package version after release of Azure.ResourceManager.ApplicationInsights (#36541) * Increment package version after release of Azure.ResourceManager.Analysis (#36539) * Add ThumbprintString property to mgmt (#36320) * Add ThumbprintString property to websites. * Add ThumbprintString for automation. * Update * Add ThumbprintString for batch * Add Thumbprint for iothub * Add ThumbprintString for notificationhubs * update * update * update * Fix test * Add obsolete attribute and make Thumbprint backwards compatible. * enable model factory (#36499) * enable model factory (#36519) * Increment package version after release of Azure.ResourceManager.AppConfiguration (#36567) * Increment package version after release of Azure.ResourceManager.AppPlatform (#36568) * Increment package version after release of Azure.ResourceManager.ArcScVmm (#36569) * Increment package version after release of Azure.ResourceManager.Attestation (#36570) * Increment package version after release of Azure.ResourceManager.Authorization (#36571) * Increment package version after release of Azure.ResourceManager.Cdn (#36576) * Increment package version after release of Azure.ResourceManager.Chaos (#36577) * Increment package version after release of Azure.ResourceManager.BotService (#36578) * Increment package version after release of Azure.ResourceManager.BillingBenefits (#36581) * Increment package version after release of Azure.ResourceManager.ChangeAnalysis (#36579) * Update AutoRest C# version to 3.0.0-beta.20230528.2 (#36574) * Update Generator Version 3.0.0-beta.20230528.2 * Update SDK codes * Introduce model factory to mgmt SDK batch 3 (#36500) * enable model factory * do not need release hci * update * enable model factory (#36527) * enable model factory (#36528) * Increment package version after release of Azure.ResourceManager.Blueprint (#36590) * Introduce model factory to mgmt SDK batch 7 (#36529) * enable model factory * update databox version * enable model factory (#36531) * enable model factory (#36559) * enable model factory (#36560) * enable model factory (#36561) * enable model factory (#36562) * enable model factory (#36566) * enable model factory (#36573) * enable model factory (#36575) * enable model factory (#36580) * enable model factory (#36582) * Introduce model factory to mgmt SDK batch 19 (#36583) * enable model factory (#36584) * enable model factory (#36585) * enable model factory (#36586) * enable model factory (#36588) * Increment package version after release of Azure.ResourceManager.Automation (#36592) * Increment package version after release of Azure.ResourceManager.Confluent (#36593) * Increment package version after release of Azure.ResourceManager.Automanage (#36594) * Increment package version after release of Azure.ResourceManager.Billing (#36595) * Increment package version after release of Azure.ResourceManager.Avs (#36597) * Increment package version after release of Azure.ResourceManager.Consumption (#36598) * Increment package version after release of Azure.ResourceManager.Communication (#36596) * Increment package version after release of Azure.ResourceManager.ConnectedVMwarevSphere (#36600) * Increment package version after release of Azure.ResourceManager.Batch (#36599) * Increment package version after release of Azure.ResourceManager.CognitiveServices (#36601) * Increment package version after release of Azure.ResourceManager.ConfidentialLedger (#36602) * enable model factory (#36589) * enable model factory (#36591) * Introduce model factory to mgmt SDK batch 13 (#36563) * Increment package version after release of Azure.ResourceManager.ContainerInstance (#36604) * Increment package version after release of Azure.ResourceManager.Datadog (#36605) * Increment package version after release of Azure.ResourceManager.DataBoxEdge (#36606) * Increment package version after release of Azure.ResourceManager.AppContainers (#36608) * Increment package version after release of Azure.ResourceManager.ContainerRegistry (#36609) * Increment package version after release of Azure.ResourceManager.DataLakeAnalytics (#36607) * Increment package version after release of Azure.ResourceManager.CustomerInsights (#36610) * Increment package version after release of Azure.ResourceManager.DataMigration (#36611) * Increment package version after release of Azure.ResourceManager.CosmosDB (#36612) * Abhishesingh msft/dtmf actions live tests (#36557) * Live test for Continuous Dtmf Detection and Send Dtmf scenario * Live test for Start Continuous Dtmf Recognition * enable model factory (#36603) * Fix deserialization for empty ResourceIdentifier (#36613) * Introduce tags related test cases (#36232) * update resourcemanager * introduce test cases, but not fully working * introduce a fix * record all the new test cases * bump version (#36617) * handle null status code (#36547) * Return CLR null for JSON elements with JsonValueKind.Null (#36552) * Return JsonElements with JsonValueKind.Null as CLR null * Add tests and return null from indexer as well. * Add cases validating exceptions are thrown * STG 88 Release Prep (#36624) * [Storage][DataMovement] Change test event asserts to CollectionAssert (#36553) * Removed Batch's project reference on Core (#36631) * Increment version for storage releases (#36629) * Increment package version after release of Azure.Storage.Blobs.Batch (#36635) * Use test registry in npmrc for alpha packages (#36628) Co-authored-by: Patrick Hallisey <[email protected]> * [Text Analytics] Rename ExtractSummary and AbstractSummary (#36555) * Enable model factory for PolicyInsights (#36618) * Increment package version after release of Azure.ResourceManager.Grafana (#36667) * Increment package version after release of Azure.ResourceManager.Kusto (#36691) * Increment package version after release of Azure.ResourceManager.HybridContainerService (#36692) * Increment package version after release of Azure.ResourceManager.ManagedServices (#36690) * Increment package version after release of Azure.ResourceManager.NetworkFunction (#36693) * Increment package version after release of Azure.ResourceManager.LabServices (#36689) * Increment package version after release of Azure.ResourceManager.GuestConfiguration (#36663) * Increment package version after release of Azure.ResourceManager.ExtendedLocations (#36664) * Increment package version after release of Azure.ResourceManager.HDInsight (#36665) * Increment package version after release of Azure.ResourceManager.MixedReality (#36696) * Increment package version after release of Azure.ResourceManager.MarketplaceOrdering (#36698) * Increment package version after release of Azure.ResourceManager.Nginx (#36697) * Increment package version after release of Azure.ResourceManager.NetApp (#36702) * Increment package version after release of Azure.ResourceManager.Network (#36701) * Increment package version after release of Azure.ResourceManager.MobileNetwork (#36700) * Increment package version after release of Azure.ResourceManager.Media (#36699) * Increment package version after release of Azure.ResourceManager.MySql (#36695) * Increment package version after release of Azure.ResourceManager.NewRelicObservability (#36694) * Increment package version after release of Azure.ResourceManager.EventGrid (#36661) * Increment package version after release of Azure.ResourceManager.MachineLearning (#36688) * Increment package version after release of Azure.ResourceManager.ManagedServiceIdentities (#36687) * Increment package version after release of Azure.ResourceManager.Marketplace (#36686) * Increment package version after release of Azure.ResourceManager.Maps (#36685) * Increment package version after release of Azure.ResourceManager.Maintenance (#36684) * Increment package version after release of Azure.ResourceManager.HybridCompute (#36683) * Increment package version after release of Azure.ResourceManager.Logic (#36682) * Increment package version after release of Azure.ResourceManager.IotHub (#36681) * Increment package version after release of Azure.ResourceManager.HybridData (#36680) * Increment package version after release of Azure.ResourceManager.Kubernetes (#36677) * Increment package version after release of Azure.ResourceManager.KeyVault (#36678) * Increment package version after release of Azure.ResourceManager.ManagementPartner (#36679) * Increment package version after release of Azure.ResourceManager.ManagedNetwork (#36676) * Increment package version after release of Azure.ResourceManager.MachineLearningCompute (#36675) * Increment package version after release of Azure.ResourceManager.LoadTesting (#36674) * Increment package version after release of Azure.ResourceManager.HybridConnectivity (#36673) * Increment package version after release of Azure.ResourceManager.KubernetesConfiguration (#36672) * Increment package version after release of Azure.ResourceManager.IotCentral (#36671) * Increment package version after release of Azure.ResourceManager.HealthcareApis (#36670) * Increment package version after release of Azure.ResourceManager.HealthBot (#36669) * Increment package version after release of Azure.ResourceManager.FluidRelay (#36668) * Increment package version after release of Azure.ResourceManager.FrontDoor (#36666) * Increment package version after release of Azure.ResourceManager.ContainerService (#36643) * Increment package version after release of Azure.ResourceManager.DataShare (#36644) * Increment package version after release of Azure.ResourceManager.DataProtectionBackup (#36645) * Increment package version after release of Azure.ResourceManager.DataBox (#36646) * Increment package version after release of Azure.ResourceManager.Dns (#36647) * Increment package version after release of Azure.ResourceManager.DataLakeStore (#36648) * Increment package version after release of Azure.ResourceManager.DevSpaces (#36649) * Increment package version after release of Azure.ResourceManager.DeviceUpdate (#36650) * Increment package version after release of Azure.ResourceManager.DeploymentManager (#36651) * Increment package version after release of Azure.ResourceManager.DnsResolver (#36652) * Increment package version after release of Azure.ResourceManager.DeviceProvisioningServices (#36653) * Increment package version after release of Azure.ResourceManager.Dynatrace (#36654) * Increment package version after release of Azure.ResourceManager.DevTestLabs (#36655) * Increment package version after release of Azure.ResourceManager.DigitalTwins (#36656) * Increment package version after release of Azure.ResourceManager.EventHubs (#36657) * Increment package version after release of Azure.ResourceManager.ElasticSan (#36658) * Increment package version after release of Azure.ResourceManager.Elastic (#36659) * Increment package version after release of Azure.ResourceManager.EdgeOrder (#36660) * Updated changelog to describe new import job feature * Sync eng/common directory with azure-sdk-tools for PR 6222 (#36703) * Updated typespec common script * Updated per the review comment --------- Co-authored-by: raychen <[email protected]> * doc for sdk release (#34837) * doc for sdl release * sdk release * sdk release * updated version in SessionRecords json file * updated version number * version changed in json file * updated version * updated version * sdk release * sdk generation * sdk release * sdk release * sdk release * Update sampes * Merge from main and regenerate code. * SDK release * sdk release * sdk release * doc for sdk release * doc for sdk release * Update --------- Co-authored-by: Wei Hu <[email protected]> * Sync eng/common directory with azure-sdk-tools for PR 6250 (#36708) * Revert the change and return tsplocation folder * Out null for the new-item command * exit if return failure when call sync script * Added repo assignment in local path scenario * Added more output * Fix path processing in windows * exit when run generate script with error --------- Co-authored-by: raychen <[email protected]> * Enable model factory for hci (#36712) * Resolve architect feedback (#36637) Resolves #36514 * Calculate `timeSinceEnqueued` for consumer spans (#36625) * calculate timesinceenqueued * refactor * Update sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Internals/TraceHelper.cs Co-authored-by: Rajkumar Rangaraj <[email protected]> * address pr comments * address pr comments * align * Address pr comments * spelling --------- Co-authored-by: Rajkumar Rangaraj <[email protected]> * [Storage][DataMovement] Add a small delay before asserting job status events (#36636) * Initial generation * Fix double line break, add API version to rest client options * Generate API * add old versions back in to fix build * creation of new test resources and updated test recordings * new bulk tests skeleton * update/add test for import api * move new test variables into service specific config file * fixing tests and updated rest api spec commit id * final testing changes * serialize entire exception in the case of test failure * initial job lifecycle sample code * add code to upload input blob to storage container for quickstart sample * updates to quickstart sample * Updated code to latest api version * Updated samples for clarity * fixed build errors * Updated changelog to describe new import job feature * updated tests and test records --------- Co-authored-by: Sebastian Herzig-Patel <[email protected]> Co-authored-by: Rachel Teitelbaum <[email protected]> Co-authored-by: Austin Lynch <[email protected]> Co-authored-by: Vishwesh Bankwar <[email protected]> Co-authored-by: Azure SDK Bot <[email protected]> Co-authored-by: James Suplizio <[email protected]> Co-authored-by: Rajarshi Sarkar <[email protected]> Co-authored-by: Rajkumar Rangaraj <[email protected]> Co-authored-by: Wei Hu <[email protected]> Co-authored-by: Chengming <[email protected]> Co-authored-by: abhishesingh-msft <[email protected]> Co-authored-by: Dapeng Zhang <[email protected]> Co-authored-by: Anne Thompson <[email protected]> Co-authored-by: Sean McCullough <[email protected]> Co-authored-by: Jacob Lauzon <[email protected]> Co-authored-by: Patrick Hallisey <[email protected]> Co-authored-by: Jose Arriaga Maldonado <[email protected]> Co-authored-by: raychen <[email protected]> Co-authored-by: rohithkumar91 <[email protected]> Co-authored-by: Wei Hu <[email protected]> Co-authored-by: Heath Stewart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #36514